Call two times find_package to detect bugs related to double calls #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging so we can use this in ami-iit/bipedal-locomotion-framework#827, feel free to comment also post-merge. |
|
Cool! Thank you @traversaro! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may sometimes happen that:
works, but:
fails. See for example ami-iit/biomechanical-analysis-framework#26, or another common case is forgetting to add a
if(TARGET targetname)before a call toadd_library(targetname IMPORTED). To catch this problems, this PR modifiescmake-package-checkto callfind_package(pkg)two times when it checks ifpkgis available.If this behavior needs to be disabled, it can be disabled with the
--disable-double-findoption.