Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librerun-sdk v0.15.0 #5

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8618482556, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

I guess I need to cleanup some patches.

@traversaro
Copy link
Contributor

There is a test failure:

2024-04-09T17:03:45.3603493Z + cmake-package-check rerun_sdk
2024-04-09T17:03:45.4492186Z ===================================
2024-04-09T17:03:45.4492868Z === Generated CMakeLists.txt file: 
2024-04-09T17:03:45.4500141Z ===================================
2024-04-09T17:03:45.4505455Z cmake_minimum_required(VERSION 3.12...3.29)
2024-04-09T17:03:45.4510682Z 
2024-04-09T17:03:45.4515480Z project(CMakePackageCheckTestCMakeProject)
2024-04-09T17:03:45.4525936Z 
2024-04-09T17:03:45.4526355Z find_package(rerun_sdk REQUIRED)
2024-04-09T17:03:45.4526503Z 
2024-04-09T17:03:45.4526685Z find_package(rerun_sdk REQUIRED)
2024-04-09T17:03:45.4526820Z 
2024-04-09T17:03:45.4526936Z 
2024-04-09T17:03:45.4527060Z 
2024-04-09T17:03:45.4527251Z # Create dummy executable
2024-04-09T17:03:45.4527537Z file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/cmake_package_check_dummy_executable.cpp "int main() {return 0;}")
2024-04-09T17:03:45.4527883Z add_executable(cmake_package_check_dummy_executable ${CMAKE_CURRENT_BINARY_DIR}/cmake_package_check_dummy_executable.cpp)
2024-04-09T17:03:45.4528359Z 
2024-04-09T17:03:45.4528472Z 
2024-04-09T17:03:45.4528674Z ===================================
2024-04-09T17:03:45.4528913Z === CMake configure output:        
2024-04-09T17:03:45.4529131Z ===================================
2024-04-09T17:03:45.6499188Z -- The C compiler identification is GNU 12.3.0
2024-04-09T17:03:45.7625309Z -- The CXX compiler identification is GNU 12.3.0
2024-04-09T17:03:45.7831641Z -- Detecting C compiler ABI info
2024-04-09T17:03:45.8947670Z -- Detecting C compiler ABI info - done
2024-04-09T17:03:45.9334460Z -- Check for working C compiler: $PREFIX/bin/x86_64-conda-linux-gnu-cc - skipped
2024-04-09T17:03:45.9347569Z -- Detecting C compile features
2024-04-09T17:03:45.9360807Z -- Detecting C compile features - done
2024-04-09T17:03:45.9519029Z -- Detecting CXX compiler ABI info
2024-04-09T17:03:46.0616444Z -- Detecting CXX compiler ABI info - done
2024-04-09T17:03:46.1009595Z -- Check for working CXX compiler: $PREFIX/bin/x86_64-conda-linux-gnu-c++ - skipped
2024-04-09T17:03:46.1023164Z -- Detecting CXX compile features
2024-04-09T17:03:46.1038728Z -- Detecting CXX compile features - done
2024-04-09T17:03:46.1095595Z -- Arrow version: 12.0.1
2024-04-09T17:03:46.1101730Z -- Found the Arrow shared library: $PREFIX/lib/libarrow.so.1200.1.0
2024-04-09T17:03:46.1107731Z -- Found the Arrow import library: ARROW_IMPORT_LIB-NOTFOUND
2024-04-09T17:03:46.1113253Z -- Found the Arrow static library: 
2024-04-09T17:03:46.1119454Z -- Rerun is using a system installed libArrow.
2024-04-09T17:03:46.1150802Z -- Rerun is using a system installed libArrow.
2024-04-09T17:03:46.1160429Z CMake Error at /home/conda/feedstock_root/build_artifacts/librerun-sdk_1712681417062/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/cmake/rerun_sdk/rerun_sdkConfig.cmake:56 (add_library):
2024-04-09T17:03:46.1161073Z   add_library cannot create ALIAS target "rerun_arrow_target" because another
2024-04-09T17:03:46.1161313Z   target with the same name already exists.
2024-04-09T17:03:46.1161522Z Call Stack (most recent call first):
2024-04-09T17:03:46.1161711Z   CMakeLists.txt:7 (find_package)

However, this is due some additional check that I added in ami-iit/cmake-package-check#6, it is not a regression of 0.15.0 w.r.t. to 0.14.0 . So I think we can skip it for now.

@traversaro
Copy link
Contributor

However, this is due some additional check that I added in ami-iit/cmake-package-check#6, it is not a regression of 0.15.0 w.r.t. to 0.14.0 . So I think we can skip it for now.

Fix in rerun-io/rerun#5886 .

Copy link
Contributor

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for upstreaming those patches.

@traversaro traversaro added the automerge Merge the PR when CI passes label Apr 9, 2024
@github-actions github-actions bot merged commit 571591a into conda-forge:main Apr 9, 2024
22 checks passed
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.15.0_hff7fa9 branch April 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants