Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ABANCA_CORP_CAGLPTPL payee name #550

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

Add support for ABANCA_CORP_CAGLPTPL payee name #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e660af
add support for ABANCA_CORP_CAGLPTPL payee name
sergiofmreis Jan 10, 2025
4e1c222
Create Release Notes file
sergiofmreis Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app-gocardless/banks/abanca_caglesmm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
export default {
...Fallback,

institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL'],
institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'],

Check failure on line 9 in src/app-gocardless/banks/abanca_caglesmm.js

View workflow job for this annotation

GitHub Actions / lint 

Replace `'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL'` with `⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix formatting to comply with Prettier rules

The array formatting needs to be adjusted to pass the linter checks.

Apply this formatting fix:

-  institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'],
+  institutionIds: [
+    'ABANCA_CAGLESMM',
+    'ABANCA_CAGLPTPL',
+    'ABANCA_CORP_CAGLPTPL',
+  ],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'],
institutionIds: [
'ABANCA_CAGLESMM',
'ABANCA_CAGLPTPL',
'ABANCA_CORP_CAGLPTPL',
],
🧰 Tools
🪛 eslint

[error] 9-9: Replace 'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL' with ⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··

(prettier/prettier)

🪛 GitHub Check: lint

[failure] 9-9:
Replace 'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL' with ⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··

🪛 GitHub Actions: Linter

[error] 9-9: Prettier formatting error: Incorrect formatting of bank identifiers list. The list should be formatted with each identifier on a new line with proper indentation.


accessValidForDays: 180,

Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/550.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Features
authors: [sergiofmreis]
---

Add support for `ABANCA_CORP_CAGLPTPL` payee name
Loading