Add support for ABANCA_CORP_CAGLPTPL payee name #550
Conversation
sergiofmreis
changed the title
WalkthroughThe pull request introduces a modification to the Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/app-gocardless/banks/abanca_caglesmm.js (1)
9-9: Consider renaming the file to better reflect its scopeThe file name
abanca_caglesmm.jssuggests specificity to CAGLESMM, but it now handles multiple Abanca variants including CAGLPTPL and CORP_CAGLPTPL. Consider renaming it to something more generic likeabanca.jsto better reflect its actual scope.🧰 Tools
🪛 eslint
[error] 9-9: Replace
'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL'with⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··(prettier/prettier)
🪛 GitHub Check: lint
[failure] 9-9:
Replace'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL'with⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··🪛 GitHub Actions: Linter
[error] 9-9: Prettier formatting error: Incorrect formatting of bank identifiers list. The list should be formatted with each identifier on a new line with proper indentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/550.mdis excluded by!**/*.md
📒 Files selected for processing (1)
src/app-gocardless/banks/abanca_caglesmm.js(1 hunks)
🧰 Additional context used
🪛 eslint
src/app-gocardless/banks/abanca_caglesmm.js
[error] 9-9: Replace 'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL' with ⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··
(prettier/prettier)
🪛 GitHub Check: lint
src/app-gocardless/banks/abanca_caglesmm.js
[failure] 9-9:
Replace 'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL' with ⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··
🪛 GitHub Actions: Linter
src/app-gocardless/banks/abanca_caglesmm.js
[error] 9-9: Prettier formatting error: Incorrect formatting of bank identifiers list. The list should be formatted with each identifier on a new line with proper indentation.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build Docker image (alpine)
🔇 Additional comments (1)
src/app-gocardless/banks/abanca_caglesmm.js (1)
Line range hint
14-23: Verify transaction normalization for the new institutionPlease confirm that the transaction normalization logic, particularly the handling of
creditorNameanddebtorNamefromremittanceInformationStructured, works correctly with transactions from ABANCA_CORP_CAGLPTPL.✅ Verification successful
Transaction normalization is correctly implemented for ABANCA_CORP_CAGLPTPL
The current implementation is specifically designed to handle ABANCA's transaction data structure where creditor/debtor names are extracted from
remittanceInformationStructured. This behavior is:
- Intentionally implemented for all ABANCA institutions
- Verified by existing test cases
- Documented in the code comments
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any special handling or test cases related to ABANCA transaction normalization rg -l "ABANCA.*transaction" test/Length of output: 81
Script:
#!/bin/bash # Find all test files and implementation files fd -e js -e ts # Then search for ABANCA-related transaction handling rg -i "abanca.*transaction|transaction.*abanca" -A 5 -B 5 # Look for similar bank normalizeTransaction implementations ast-grep --pattern 'normalizeTransaction(transaction, $_) { $$$ }'Length of output: 6794
🧰 Tools
🪛 eslint
[error] 9-9: Replace
'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL'with⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··(prettier/prettier)
🪛 GitHub Check: lint
[failure] 9-9:
Replace'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL'with⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··🪛 GitHub Actions: Linter
[error] 9-9: Prettier formatting error: Incorrect formatting of bank identifiers list. The list should be formatted with each identifier on a new line with proper indentation.
| @@ -6,7 +6,7 @@ | |||
| export default { | |||
| ...Fallback, | |||
|
|
|||
| institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL'], | |||
| institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'], | |||
There was a problem hiding this comment.
Fix formatting to comply with Prettier rules
The array formatting needs to be adjusted to pass the linter checks.
Apply this formatting fix:
- institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'],
+ institutionIds: [
+ 'ABANCA_CAGLESMM',
+ 'ABANCA_CAGLPTPL',
+ 'ABANCA_CORP_CAGLPTPL',
+ ],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL', 'ABANCA_CORP_CAGLPTPL'], | |
| institutionIds: [ | |
| 'ABANCA_CAGLESMM', | |
| 'ABANCA_CAGLPTPL', | |
| 'ABANCA_CORP_CAGLPTPL', | |
| ], |
🧰 Tools
🪛 eslint
[error] 9-9: Replace 'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL' with ⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··
(prettier/prettier)
🪛 GitHub Check: lint
[failure] 9-9:
Replace 'ABANCA_CAGLESMM',·'ABANCA_CAGLPTPL',·'ABANCA_CORP_CAGLPTPL' with ⏎····'ABANCA_CAGLESMM',⏎····'ABANCA_CAGLPTPL',⏎····'ABANCA_CORP_CAGLPTPL',⏎··
🪛 GitHub Actions: Linter
[error] 9-9: Prettier formatting error: Incorrect formatting of bank identifiers list. The list should be formatted with each identifier on a new line with proper indentation.
No description provided.