Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Details text update to "Quick Edit" #67725

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Site Editor Details text update to "Quick Edit" #67725

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38edcaa
site editor details text update
benazeer-ben Dec 9, 2024
5b2c439
Quick edit labelmin side panel
benazeer-ben Dec 9, 2024
859eee6
Merge branch 'trunk' of https://github.com/benazeer-ben/gutenberg int…
benazeer-ben Jan 15, 2025
5f7a52c
Feedback changes
benazeer-ben Jan 15, 2025
1610fa9
Feedback changes - Updates limiting to edit site
benazeer-ben Jan 15, 2025
0afcb11
lint update
benazeer-ben Jan 15, 2025
afb7072
Feedback changes
benazeer-ben Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/post-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ export default function PostList( { postType } ) {
size="compact"
isPressed={ quickEdit }
icon={ drawerRight }
label={ __( 'Details' ) }
label={ __( 'Quick Edit' ) }
onClick={ () => {
history.navigate(
addQueryArgs( location.path, {
Expand Down
10 changes: 9 additions & 1 deletion packages/editor/src/components/post-card-panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
__experimentalVStack as VStack,
__experimentalText as Text,
privateApis as componentsPrivateApis,
__experimentalHeading as Heading,
} from '@wordpress/components';
import { store as coreStore } from '@wordpress/core-data';
import { useSelect } from '@wordpress/data';
Expand Down Expand Up @@ -99,6 +100,13 @@ export default function PostCardPanel( {

return (
<VStack spacing={ 1 } className="editor-post-card-panel">
<Heading
level={ 2 }
size={ 16 }
className="editor-post-card-panel__heading"
>
{ __( 'Quick Edit' ) }
</Heading>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PostCardPanel is also used inside the editor. Any changes to it affect editors globally. We should be careful and avoid visual regressions.

Screenshot

CleanShot 2025-01-15 at 16 44 22

Copy link
Contributor Author

@benazeer-ben benazeer-ben Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! @Mamaduka
That's right. Updated in last commit.

<HStack
spacing={ 2 }
className="editor-post-card-panel__header"
Expand All @@ -109,7 +117,7 @@ export default function PostCardPanel( {
numberOfLines={ 2 }
truncate
className="editor-post-card-panel__title"
as="h2"
as="h3"
>
<span className="editor-post-card-panel__title-name">
{ title }
Expand Down
4 changes: 4 additions & 0 deletions packages/editor/src/components/post-card-panel/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,8 @@
.editor-post-card-panel__description {
color: $gray-700;
}

.editor-post-card-panel__heading {
margin-bottom: $grid-unit-20;
}
}
Loading