Site Editor Details text update to "Quick Edit" #67725
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Feature] DataViews
| @@ -178,6 +178,7 @@ export function PostEdit( { postType, postId } ) { | |||
| } ) } | |||
| label={ __( 'Post Edit' ) } | |||
| > | |||
| <h2>{ __( 'Quick Edit' ) }</h2> | |||
There was a problem hiding this comment.
It's best to use a Heading component instead of a hardcoded H2:
<Heading level={ 2 } size={ 16 }>
{ __( 'Quick Edit' ) }
</Heading>
There was a problem hiding this comment.
@benazeer-ben thanks for working on this.
I left a note about the hardcoded H2.
Also, now that the panel starts with a new H2 heading, the post title in the panel should be changed to a h3. Otherwise, the headings hierarchy wouldn't be ideal with two H2. Screenshot to illustrate:
I guess that would need some minor adjustments to the margins.
|
This will also need design feedback since adding a static header diverges from the original designs. |
…o site-editor-details-text-update
|
Hi @Mamaduka Thank you for your feedback! I’ve updated the code based on your suggestions: Moved the 'Quick Edit' heading to the post-card-panel and applied the required margin for proper spacing. Please review the changes. I’m happy to incorporate any additional design suggestions. |
| <Heading | ||
| level={ 2 } | ||
| size={ 16 } | ||
| className="editor-post-card-panel__heading" | ||
| > | ||
| { __( 'Quick Edit' ) } | ||
| </Heading> |
There was a problem hiding this comment.
This PostCardPanel is also used inside the editor. Any changes to it affect editors globally. We should be careful and avoid visual regressions.
Screenshot
There was a problem hiding this comment.
Yes! @Mamaduka
That's right. Updated in last commit.
What?
Fixes #66612
Why?
The term 'Details' is not matching with the context. So updating it to 'Quick Edit'.
How?
Changing the text 'Details' to 'Quick Edit'.
Testing Instructions
Screenshots