Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] #103529 - Introduce hotkey for "Save and Close" #173

Merged
merged 6 commits into from
Aug 5, 2024
Merged

[FEATURE] #103529 - Introduce hotkey for "Save and Close" #173

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a78fb41
[FEATURE] #103529 - Introduce hotkey for "Save and Close"
sfinnerWco Aug 2, 2024
2e9072d
[TASK] Add tips with reference to Keyboard commands in several Conten…
sfinnerWco Aug 3, 2024
bdbb8f1
[FIX] Renaming the headline to not irritate users (could think of RTE…
sfinnerWco Aug 3, 2024
62807e5
[FIX] Outsource tip into include File, renaming to backend forms in t…
sfinnerWco Aug 5, 2024
5474b94
[FIX] Rename include file due to check fail
sfinnerWco Aug 5, 2024
ac5388b
Apply suggestions from code review
froemken Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Documentation/ContentElements/Content/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,9 @@ Highlighted areas will then show you where you can drop it.

You can move a content element from one page to another in the :guilabel:`Web
> List` module using cut and paste. Refer to the :ref:`clipboard chapter <clipboard>` for information about using the clipboard in the :guilabel:`List` module.

.. tip::

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also use "backend forms" here, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the hint. I will change it in this parts as well

6 changes: 6 additions & 0 deletions Documentation/ContentElements/CreatingContent/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,3 +143,9 @@ Add new content to a page
:class: with-shadow

The new content element appears in the Page module

.. tip::

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same as above)

6 changes: 6 additions & 0 deletions Documentation/ContentElements/EditingContent/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,9 @@ display different input fields.

This action does not delete content. It is saved in the background and will be
restored if you select the applicable content element type again.

.. tip::

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this happens multiple times,
how do you think about outsourcing this tip as a rst include file and doing an include of that at the current places?
(I can also do that in a follow-up, but if you'd be interested to do it, that would be a great help!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do that, yeah. Is there any convention for where to place that include file? Like in "Documentation/ContentElements/Includes" or just place it in the existing ContentElements Folder next to the Index.rst?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repo we don't have includes yet. In the Core API docs we often create subdirectories only when more than one file is included.

In your case here I would put a file like "TipHotkeys.rst" or so just into the same directory as Index.rst, yes. We can move it later when more includes happen.

Thanks! :)

6 changes: 6 additions & 0 deletions Documentation/ContentElements/Images/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,9 @@ Behavior
--------

Use the :guilabel:`Enlarge on Click` setting to enable a lightbox display for the image.

.. tip::

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.
6 changes: 6 additions & 0 deletions Documentation/ContentElements/Media/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,9 @@ start playing as soon as the page loads.
You can configure various settings for media files (for example, adding a
border, setting page position and behavior) just as you would to
:ref:`configure an image<Configure-the-image>`.

.. tip::

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.
6 changes: 6 additions & 0 deletions Documentation/ContentElements/RichTextEditor/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,9 @@ Removing a link

To remove a link from text, put your cursor anywhere in the linked text then
click the :guilabel:`Unlink` icon on the toolbar.

.. tip::

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.
14 changes: 14 additions & 0 deletions Documentation/HelpInside/KeyboardCommands/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@ the guidelines set out in `WAI-ARIA Authoring Practices 1.1. <https://www.w3.org
* :kbd:`Right` arrow key will expand the focus if possible.
* :kbd:`Left` arrow key will close the focus if possible.

Actions in backend forms
=========================

.. tabs::

.. group-tab:: Windows / Linux

* :kbd:`ctrl` + :kbd:`s` = Save
* :kbd:`ctrl` + :kbd:`shift` + :kbd:`s` = Save and close

.. group-tab:: macOs

* :kbd:`cmd (⌘)` + :kbd:`s` = Save
* :kbd:`cmd (⌘)` + :kbd:`shift` + :kbd:`s` = Save and close
froemken marked this conversation as resolved.
Show resolved Hide resolved

Editing text in the Rich Text Editor (RTE)
==========================================
Expand Down