Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] #103529 - Introduce hotkey for "Save and Close" #173

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

sfinnerWco
Copy link
Contributor

@garvinhicking
Copy link

Do you want to work more on it, as it's a draft? I think it is an improvement even now :) Thanks!!

@sfinnerWco
Copy link
Contributor Author

I put it in as a draft cause I wanted to also reference the keyboard commands page inside different Subpages of the "Content Elements" Page - for letting users know better that there are shortcuts in the editor.

According to your suggestion to name ist "Actions in backend forms" I agree, I will change that!

@sfinnerWco sfinnerWco marked this pull request as ready for review August 3, 2024 12:16

If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also use "backend forms" here, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the hint. I will change it in this parts as well


If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same as above)


If you are more comfortable using shortcuts, there are different kinds of
:ref:`keyboard commands <t3editors:keyboard_commands>` you can use in
the Backend Editor.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this happens multiple times,
how do you think about outsourcing this tip as a rst include file and doing an include of that at the current places?
(I can also do that in a follow-up, but if you'd be interested to do it, that would be a great help!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do that, yeah. Is there any convention for where to place that include file? Like in "Documentation/ContentElements/Includes" or just place it in the existing ContentElements Folder next to the Index.rst?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repo we don't have includes yet. In the Core API docs we often create subdirectories only when more than one file is included.

In your case here I would put a file like "TipHotkeys.rst" or so just into the same directory as Index.rst, yes. We can move it later when more includes happen.

Thanks! :)

…he tip similar to the headline in Keyboard Commands Page.
@garvinhicking
Copy link

Let me know when you're ready on your side, then I'll render and merge this. 👍

@sfinnerWco
Copy link
Contributor Author

I guess I have to rename the file to .rst.txt as an include (at least it's like this in the Core API docs).
Afterwards it's ready for me.

@sfinnerWco
Copy link
Contributor Author

should be fine now I hope!

@froemken froemken merged commit 260d62d into TYPO3-Documentation:main Aug 5, 2024
1 check passed
@garvinhicking
Copy link

Many thanks for working on it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants