Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heroes of Might and Magic IV #1144
base: master
Are you sure you want to change the base?
Add Heroes of Might and Magic IV #1144
Changes from 33 commits
254649c
63f898c
71cd3d8
60c3cb5
69e7bf2
5bf56fe
1c4fe31
66bd276
1791c28
9d473d3
afeb994
25b45d5
43932a3
8db0264
2cfd676
8b7a82a
b1b30ac
c21fb41
923f809
d3b3b61
dc204af
5bc1ecc
968f5fb
102486e
3d800f6
cdb5c19
63006a6
65de732
f14a61f
a728085
fbbfdb8
84af7b0
9e64476
9254cf1
ed10422
b5dabbe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this folder really correct?
Heroes of Might & Magic IV - Złota Edycja
looks to me like a localized (translated) string and nothing a publisher would normally useThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a default install location of my cd disc. I've set it in GOG local installer and it is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madoar is correct. This will very likely not work in other countries. Maybe you can solve it with a regular expression. So:
ls
for the "Ubisoft" folder and then find the "Heroes of Might & Magic IV" folder.Could even be enough to use startsWith.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plata the "Ubisoft" part is only there when you install from the disc. GOG installer uses "GOG.com" instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have different installers then?