Add Heroes of Might and Magic IV #1144

Zemogiter · 2019-12-01T11:11:48Z

Description

When the wineprefix is created and just before the selected .exe file is launched, installation crashes with this error:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Input/Output error
	at java.base/java.io.FileInputStream.readBytes(Native Method)
	at java.base/java.io.FileInputStream.read(FileInputStream.java:257)
	at org.apache.commons.io.input.ProxyInputStream.read(ProxyInputStream.java:78)
	at org.phoenicis.win32.pe.PEReader.readDosHeader(PEReader.java:93)
	at org.phoenicis.win32.pe.PEReader.parseExecutable(PEReader.java:30)
	at org.phoenicis.tools.win32.ExeAnalyser.isArchitecture(ExeAnalyser.java:62)
	at org.phoenicis.tools.win32.ExeAnalyser.is64Bits(ExeAnalyser.java:46)
	at <js> run(Unnamed:413:15444-15490)
	at <js> run(Unnamed:171:5412-5502)
	at <js> go(Unnamed:88:3412-3493)
	at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke(HostInteropReflect.java:678)
	at com.sun.proxy.$Proxy66.go(Unknown Source)
	at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:237)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by host exception: java.io.IOException: Błąd wejścia/wyjścia

[WARNING] 
org.graalvm.polyglot.PolyglotException: Input/Output error
    at java.io.FileInputStream.readBytes (Native Method)
    at java.io.FileInputStream.read (FileInputStream.java:257)
    at org.apache.commons.io.input.ProxyInputStream.read (ProxyInputStream.java:78)
    at org.phoenicis.win32.pe.PEReader.readDosHeader (PEReader.java:93)
    at org.phoenicis.win32.pe.PEReader.parseExecutable (PEReader.java:30)
    at org.phoenicis.tools.win32.ExeAnalyser.isArchitecture (ExeAnalyser.java:62)
    at org.phoenicis.tools.win32.ExeAnalyser.is64Bits (ExeAnalyser.java:46)
    at <js>.run (Unnamed:413)
    at <js>.run (Unnamed:171)
    at <js>.go (Unnamed:88)
    at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke (HostInteropReflect.java:678)
    at com.sun.proxy.$Proxy66.go (Unknown Source)
    at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:237)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)

This error is caused by the setup.exe file in my cd disc being weird. Not corrupted because installation from it works in Windows. However I tried a local GOG installer and it works just fine.

The main objective is to get this game to work and install this mod:
https://equilibris.celestialheavens.com/eng/downloads.html
To fix game balance and bugs.

What works

Installation using GOG installation file and the game itself

What was not tested

~~Running the Equilibris mod due to the script searching for H4mod.exe file right after the game installation process ends. This file is created after the mod installation is finished.~~ Fixed by #1170
Now it's the equi.aop file download that crashes the script:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Download of https://equilibris.celestialheavens.com/downloads/equi.aop has failed
	at org.phoenicis.tools.http.Downloader.get(Downloader.java:108)
	at org.phoenicis.tools.http.Downloader.get(Downloader.java:81)
	at <js> get(Unnamed:135-144:3540-3841)
	at <js> :=>(Unnamed:37-42:1612-1857)
	at <js> go(Unnamed:98:3725-3760)
	at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke(HostInteropReflect.java:678)
	at com.sun.proxy.$Proxy68.go(Unknown Source)
	at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:237)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by host exception: org.phoenicis.tools.http.DownloadException: Download of https://equilibris.celestialheavens.com/downloads/equi.aop has failed

[WARNING] 
org.graalvm.polyglot.PolyglotException: Download of https://equilibris.celestialheavens.com/downloads/equi.aop has failed
    at org.phoenicis.tools.http.Downloader.get (Downloader.java:108)
    at org.phoenicis.tools.http.Downloader.get (Downloader.java:81)
    at <js>.get (Unnamed:135)
    at <js>.:=> (Unnamed:37)
    at <js>.go (Unnamed:98)
    at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke (HostInteropReflect.java:678)
    at com.sun.proxy.$Proxy68.go (Unknown Source)
    at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:237)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)

Test

Operating system (and linux kernel version): Ubuntu 19.10 5.3.0-23-generic
Hardware (GPU/CPU):
i7-7700K, GTX1080 ti

Ready for review

Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
json-align and eslint run according to the documentation.
Codacy and travis checked.

Merged current master

Update the fork with changes from master fork.

Fix JSDoc (PhoenicisOrg#538)

Fork update

merge changes

Merging changes to the fork

Merging updates from master fork

Merging changes from master

Merge from master branch

Merge master fork

Updated the way virtual desktop plugin is used.

Merge master fork

plata · 2019-12-04T17:30:07Z

Can you translate this:

Caused by host exception: java.io.IOException: Błąd wejścia/wyjścia

?

Zemogiter · 2019-12-04T19:04:06Z

Input/output error

madoar · 2019-12-12T20:27:59Z

Most likely something is wrong with either the exe file itself or the handling code of it.

Zemogiter · 2019-12-13T09:39:40Z

Just tried launching the setup.exe in vanilla wine. I got a error screen with three rectangular symbols (usually used when something dosen't recorgnize a character) followed by 9 "file not found" messages, each appearing after the previous one was closed. The file works fine in Windows 64bit so it's a Wine issue.
UPDATE: Tried wine version 3.0.3 because it was the latest one tested in AppDB. Same error happens.

madoar · 2019-12-15T21:50:02Z

By wine error you mean an error unrelated to phoenicis or is it because of something happening in phoenicis-winebuild?

Zemogiter · 2019-12-17T10:43:50Z

I think it's unrelated to phoenicis because I get errors when launching setup.exe file regardless.

Added the rest of necessary files (self extracting archives, needed becuase Equilibris is chesksum-sensitive), code cleanup.

Zemogiter · 2019-12-19T10:29:57Z

Tried my instalation disc in Lutris. Dosen't work there as well. Tried GOG installer and it works. But the default installation directory is different than installing from CD.
UPDATE: It seems my iso file was corrupted all along...
Because when use a physical disc the exe file starts ~~and installation goes normally.~~ Installation crashes with an error. I'll see if it will work on windows.
UPDATE 2: The disc works fine on windows.

plata · 2019-12-28T12:05:12Z

@Zemogiter you've marked this as ready for review but the PR description says that nothing is working. What's the status of this PR?

Zemogiter · 2019-12-28T14:58:32Z

@plata op just updated

Fixed typos, using consts instead of vars.

Applications/Games/Heroes of Might & Magic IV/Local (Gold Edition)/script.js

Corrected wizard usage, using new wine version calling

Applications/Games/Heroes of Might & Magic IV/Local (Gold Edition)/script.js

madoar · 2020-01-03T15:09:20Z

@Zemogiter how is the current state of this PR? Is it installable/runnable or is it still work in progress?

Zemogiter · 2020-01-03T21:05:44Z

@madoar For some reason the script ignores the postInstall() stage and tries to look for H4mod.exe file which dosen't exist yet.

madoar · 2020-01-04T00:39:49Z

... and tries to look for H4mod.exe file which dosen't exist yet.

You mean during shortcut creation?

The reason is that the postInstall hook is executed after the installation has been finished and the shortcut been created. See:

scripts/Engines/Wine/QuickScript/Installer Script/script.js

Lines 84 to 100 in 0718546

    
           this._preInstall(wine, setupWizard); 
        
           // back to generic wait (might have been changed in preInstall) 
        
           setupWizard.wait(tr("Please wait...")); 
        
           wine.run(installationCommand.command, installationCommand.args, null, false, true); 
        
           // if no executable given, ask user 
        
           if (!this._executable) { 
        
               this._executable = fileName( 
        
                   setupWizard.browse(tr("Please select the executable."), wine.prefixDirectory(), ["exe"]) 
        
               ); 
        
           } 
        
           this._createShortcut(wine.prefix()); 
        
           this._postInstall(wine, setupWizard);

Maybe you want to use the preInstall hook instead?

Zemogiter · 2020-01-04T08:12:27Z

That is not possible because the game must be installed in order to run both patch resources and mod resource.
A better option would be to swap places with this._createShortcut and this._postInstall

madoar · 2020-01-04T19:24:35Z

@plata what do you think, should we swap this._createShortcut and this._postInstall?

plata · 2020-01-04T19:34:08Z

I have something in the back of my head that we had a reason to do it like this. I cannot remember though.

Zemogiter · 2020-01-04T21:17:03Z

After the latest commit and swaping shortcut and postInstall the two patch files download and run successfully. But equi.aop crashes:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Download of https://equilibris.celestialheavens.com/downloads/equi.aop has failed
	at org.phoenicis.tools.http.Downloader.get(Downloader.java:108)
	at org.phoenicis.tools.http.Downloader.get(Downloader.java:81)
	at <js> get(Unnamed:135-144:3540-3841)
	at <js> :=>(Unnamed:37-42:1612-1857)
	at <js> go(Unnamed:98:3725-3760)
	at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke(HostInteropReflect.java:678)
	at com.sun.proxy.$Proxy68.go(Unknown Source)
	at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:237)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by host exception: org.phoenicis.tools.http.DownloadException: Download of https://equilibris.celestialheavens.com/downloads/equi.aop has failed

[WARNING] 
org.graalvm.polyglot.PolyglotException: Download of https://equilibris.celestialheavens.com/downloads/equi.aop has failed
    at org.phoenicis.tools.http.Downloader.get (Downloader.java:108)
    at org.phoenicis.tools.http.Downloader.get (Downloader.java:81)
    at <js>.get (Unnamed:135)
    at <js>.:=> (Unnamed:37)
    at <js>.go (Unnamed:98)
    at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke (HostInteropReflect.java:678)
    at com.sun.proxy.$Proxy68.go (Unknown Source)
    at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:237)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)

madoar · 2020-01-04T22:33:29Z

Applications/Games/Heroes of Might & Magic IV/Local (Gold Edition)/script.js

+    .wineVersion(getLatestDevelopmentVersion)
+    .executable("H4mod.exe")
+    .postInstall((wine) => {
+        const dataDirectory = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "Ubisoft/Heroes of Might & Magic IV - Złota Edycja/Data";


Is this folder really correct? Heroes of Might & Magic IV - Złota Edycja looks to me like a localized (translated) string and nothing a publisher would normally use

This is a default install location of my cd disc. I've set it in GOG local installer and it is correct.

@madoar is correct. This will very likely not work in other countries. Maybe you can solve it with a regular expression. So: ls for the "Ubisoft" folder and then find the "Heroes of Might & Magic IV" folder.
Could even be enough to use startsWith.

@plata the "Ubisoft" part is only there when you install from the disc. GOG installer uses "GOG.com" instead

Shouldn't we have different installers then?

Adding wine.wait() so user won't get two patch windows at the same time.

Zemogiter added 28 commits March 27, 2018 22:15

Merge pull request #1 from PhoenicisOrg/master

254649c

Merged current master

Merge pull request #3 from PhoenicisOrg/master

63f898c

Update the fork with changes from master fork.

Merge pull request #4 from PhoenicisOrg/master

71cd3d8

Fix JSDoc (PhoenicisOrg#538)

Merge pull request #5 from PhoenicisOrg/master

60c3cb5

Fork update

Merge pull request #6 from PhoenicisOrg/master

69e7bf2

merge changes

Merge pull request #7 from PhoenicisOrg/master

5bf56fe

Merging changes to the fork

Merge pull request #8 from PhoenicisOrg/master

1c4fe31

Merging updates from master fork

Merge pull request #9 from PhoenicisOrg/master

66bd276

Merging changes from master

Add files via upload

1791c28

Merge pull request #22 from PhoenicisOrg/master

9d473d3

Merge from master branch

Merge pull request #23 from PhoenicisOrg/master

afeb994

Merge master fork

Update script.js

25b45d5

Updated the way virtual desktop plugin is used.

Update script.js

43932a3

Update script.js

8db0264

Update script.js

2cfd676

Update script.js

8b7a82a

Update script.js

b1b30ac

Update script.js

c21fb41

Merge pull request #24 from PhoenicisOrg/master

923f809

Merge master fork

Merge pull request #30 from PhoenicisOrg/master

d3b3b61

Merge master fork

Add files via upload

dc204af

Update script.js

5bc1ecc

Update script.js

968f5fb

Update script.json

102486e

Update application.json

3d800f6

Update script.json

cdb5c19

Update application.json

63006a6

Update script.json

65de732

Zemogiter added 2 commits December 17, 2019 12:33

Update script.js

f14a61f

Update script.js

a728085

Added the rest of necessary files (self extracting archives, needed becuase Equilibris is chesksum-sensitive), code cleanup.

Zemogiter marked this pull request as ready for review December 20, 2019 10:18

madoar added the WIP Work in progress label Dec 23, 2019

Update script.js

fbbfdb8

Fixed typos, using consts instead of vars.

madoar requested changes Jan 2, 2020

View reviewed changes

Zemogiter added 2 commits January 2, 2020 16:10

Update script.js

84af7b0

Corrected wizard usage, using new wine version calling

Update script.js

9e64476

madoar requested changes Jan 3, 2020

View reviewed changes

Applications/Games/Heroes of Might & Magic IV/Local (Gold Edition)/script.js Outdated Show resolved Hide resolved

Update script.js

9254cf1

Update script.js

ed10422

madoar reviewed Jan 4, 2020

View reviewed changes

Zemogiter mentioned this pull request Jan 5, 2020

Update Installer Script (run postInstall before shortcut creation) #1170

Merged

3 tasks

Update script.js

b5dabbe

Adding wine.wait() so user won't get two patch windows at the same time.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Heroes of Might and Magic IV #1144

Add Heroes of Might and Magic IV #1144

Zemogiter commented Dec 1, 2019 •

edited

Loading

plata commented Dec 4, 2019

Zemogiter commented Dec 4, 2019

madoar commented Dec 12, 2019

Zemogiter commented Dec 13, 2019 •

edited

Loading

madoar commented Dec 15, 2019

Zemogiter commented Dec 17, 2019 •

edited

Loading

Zemogiter commented Dec 19, 2019 •

edited

Loading

plata commented Dec 28, 2019

Zemogiter commented Dec 28, 2019

madoar commented Jan 3, 2020

Zemogiter commented Jan 3, 2020

madoar commented Jan 4, 2020

Zemogiter commented Jan 4, 2020 •

edited

Loading

madoar commented Jan 4, 2020 •

edited

Loading

plata commented Jan 4, 2020

Zemogiter commented Jan 4, 2020 •

edited

Loading

madoar Jan 4, 2020

Zemogiter Jan 5, 2020

plata Jan 5, 2020

Zemogiter Jan 7, 2020

plata Jan 8, 2020

Add Heroes of Might and Magic IV #1144

Are you sure you want to change the base?

Add Heroes of Might and Magic IV #1144

Conversation

Zemogiter commented Dec 1, 2019 • edited Loading

Description

What works

What was not tested

Test

Ready for review

plata commented Dec 4, 2019

Zemogiter commented Dec 4, 2019

madoar commented Dec 12, 2019

Zemogiter commented Dec 13, 2019 • edited Loading

madoar commented Dec 15, 2019

Zemogiter commented Dec 17, 2019 • edited Loading

Zemogiter commented Dec 19, 2019 • edited Loading

plata commented Dec 28, 2019

Zemogiter commented Dec 28, 2019

madoar commented Jan 3, 2020

Zemogiter commented Jan 3, 2020

madoar commented Jan 4, 2020

Zemogiter commented Jan 4, 2020 • edited Loading

madoar commented Jan 4, 2020 • edited Loading

plata commented Jan 4, 2020

Zemogiter commented Jan 4, 2020 • edited Loading

madoar Jan 4, 2020

Choose a reason for hiding this comment

Zemogiter Jan 5, 2020

Choose a reason for hiding this comment

plata Jan 5, 2020

Choose a reason for hiding this comment

Zemogiter Jan 7, 2020

Choose a reason for hiding this comment

plata Jan 8, 2020

Choose a reason for hiding this comment

Zemogiter commented Dec 1, 2019 •

edited

Loading

Zemogiter commented Dec 13, 2019 •

edited

Loading

Zemogiter commented Dec 17, 2019 •

edited

Loading

Zemogiter commented Dec 19, 2019 •

edited

Loading

Zemogiter commented Jan 4, 2020 •

edited

Loading

madoar commented Jan 4, 2020 •

edited

Loading

Zemogiter commented Jan 4, 2020 •

edited

Loading