Cargo workflow #21
Merged
Cargo workflow #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally fixed the issue. Somehow, for new nightly releases, cargo fmt output is not consistent. 🤦 Tried a lot of different things, cost me some hours... |
ozgunozerk
modified the milestone:
First version of the template (XCM + multisig + proxy)
1 task
|
Will squash-merge, commit history is not important for this PR |
4meta5
reviewed
Nov 27, 2023
4meta5
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
for cargo check: clippy itself runs cargo check: https://github.com/rust-lang/rust-clippy/blob/c154754b74577906c5d55d57f7daeff02d6a33e7/src/main.rs#L59
Didn't know this, thanks for sharing!
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is providing a template for running the most important cargo commands in our CI-test.
We can use this CI as a condition in our PRs, so even if we forget to run cargo clippy for example, github won't :)
I've configured it, so that it will only run the test in ubuntu machines, but not on windows and macos. I thought running on all 3 major OS for each run would be an overkill.
If we want to run the test on macos and windows, I've added a dispatch option, we can manually dispatch this test on macos and windows.