Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 [Bug]: fix CI to check runtime compiles #28

Closed
4 tasks done
4meta5 opened this issue Nov 29, 2023 · 0 comments · Fixed by #46
Closed
4 tasks done

🐞 [Bug]: fix CI to check runtime compiles #28

4meta5 opened this issue Nov 29, 2023 · 0 comments · Fixed by #46
Assignees
@4meta5
Labels
bug Something isn't working
Milestone
1st Deliverable MVP

Comments

@4meta5
Copy link
Contributor

4meta5 commented Nov 29, 2023 •
edited
Loading

What happened?

2 bugs introduced in #21

  1. CI does not compile runtime to WASM (shown in expected behavior report below)
  2. CI compiles test --release which limits common test utilities commonly used in std testing environment commonly used

platform

  • linux
  • windows
  • macos

Expected behavior

  1. Excluding pallet-proxy/std from std dependencies in runtime should have led to a CI error because the node cannot compile runtime to WASM without it included (see 🐞 [Bug]: Include pallet-proxy for all its features in runtime #38 and Fix runtime build by including all proxy features #40)
  2. CI should compile test without passing --release flag

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@4meta5 4meta5 added the bug Something isn't working label Nov 29, 2023
@4meta5 4meta5 added this to the 1st Deliverable milestone Nov 30, 2023
@4meta5 4meta5 mentioned this issue Dec 1, 2023
Merged
@4meta5 4meta5 changed the title 🐞 [Bug]: fix CI to (1) compile runtime to WASM (2) provide tests with access to std 🐞 [Bug]: fix CI to check runtime compiles Dec 1, 2023
@4meta5 4meta5 mentioned this issue Dec 4, 2023
Merged
@4meta5 4meta5 self-assigned this Dec 4, 2023
@4meta5 4meta5 moved this from Todo to In Development in Substrate Runtime Templates Dec 4, 2023
@4meta5 4meta5 closed this as completed in #46 Dec 4, 2023
@github-project-automation github-project-automation bot moved this from In Development to Done in Substrate Runtime Templates Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4meta5 4meta5

Labels
bug Something isn't working
Projects
Substrate Runtime Templates
Archived in project
Milestone
1st Deliverable MVP
Development

Successfully merging a pull request may close this issue.

Fix CI to check build and run tests in std OpenZeppelin/polkadot-runtime-templates
1 participant
@4meta5