Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PDB and probes, drop unspecified acl in sentinel helm #1123

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Dariusch
Copy link
Contributor

@Dariusch Dariusch commented Nov 7, 2024

Description

This pull request includes several updates to the Redis Sentinel Helm chart, focusing on the removal of ACL-related configuration and the addition of Pod Disruption Budget (PDB) and probe configurations.

  • Removal of ACL Configuration
  • Added PDB and probe configuration options (livenessProbe, readinessProbe) to charts/redis-sentinel/README.md.
  • Added PDB and probe configuration blocks to charts/redis-sentinel/templates/redis-sentinel.yaml.
  • Added PDB and probe configuration defaults to charts/redis-sentinel/values.yaml.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

The probe values were taken from the in-cluster rendered defaults for our RedisSentinel deployment.

In addition, I was wondering if there are any plans to support a PDB for redis-replication.

Signed-off-by: Dariusch Ochlast <dariusch.ochlast@gmail.com>
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.23%. Comparing base (d121d86) to head (f1cffe6).
Report is 130 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
+ Coverage   35.20%   44.23%   +9.02%     
==========================================
  Files          19       20       +1     
  Lines        3213     3423     +210     
==========================================
+ Hits         1131     1514     +383     
+ Misses       2015     1822     -193     
- Partials       67       87      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit efb9624 into OT-CONTAINER-KIT:master Nov 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants