Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdb value mapping in redis-sentinel #1136

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Dariusch
Copy link
Contributor

Description

The pdb values are not applied correctly. This PR is fixing it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Previous PR #1123

Signed-off-by: Dariusch Ochlast <dariusch.ochlast@gmail.com>
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.95%. Comparing base (d121d86) to head (fc15390).
Report is 140 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   35.20%   29.95%   -5.25%     
==========================================
  Files          19       54      +35     
  Lines        3213     6243    +3030     
==========================================
+ Hits         1131     1870     +739     
- Misses       2015     4182    +2167     
- Partials       67      191     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit 53b95a0 into OT-CONTAINER-KIT:master Nov 18, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants