Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable INP support without ODB libraries #10990

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Enable INP support without ODB libraries #10990

merged 5 commits into from
Jan 3, 2024

Conversation

jonjenssen
Copy link
Collaborator

Closes #10676

@jonjenssen jonjenssen enabled auto-merge (squash) December 28, 2023 17:21
@jonjenssen jonjenssen requested a review from kriben January 2, 2024 14:56
kriben
kriben requested changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good code. Minor nitpick about duplication.

ApplicationLibCode/Commands/GeoMechCommands/RicImportGeoMechCaseTimeStepFilterFeature.cpp Show resolved Hide resolved
@jonjenssen jonjenssen disabled auto-merge January 3, 2024 10:55
@jonjenssen jonjenssen merged commit 50a7665 into dev Jan 3, 2024
17 checks passed
@jonjenssen jonjenssen deleted the inp_without_odb branch January 3, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriben kriben kriben requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable INP file support for non-ODB builds
2 participants
@jonjenssen @kriben