Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-level function to lookup symbols #84

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Add top-level function to lookup symbols #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions gen/nvml/lib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/**
# Copyright 2023 NVIDIA CORPORATION
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
**/

package nvml

import "fmt"

// LookupSymbol provides top-level access to symbol lookup in the configured library.
// Note that this requires that the library be loaded as is done in a call to nvml.Init().
//
// Deprecated: LookupSymbol represents an unstable API and should be considered experimental.
func LookupSymbol(name string) error {
if nvml == nil {
return fmt.Errorf("error looking up %s: library %s not initialized", name, nvmlLibraryName)
}
return nvml.Lookup(name)
}
Comment on lines +25 to +30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make more sense to provide a function that just returns the nvml library itsself and then allow them to call Lookup() on that (or whatever other operation we may have on the DynamicLibrary type in the future)?

30 changes: 30 additions & 0 deletions pkg/nvml/lib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/**
# Copyright 2023 NVIDIA CORPORATION
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
**/

package nvml

import "fmt"

// LookupSymbol provides top-level access to symbol lookup in the configured library.
// Note that this requires that the library be loaded as is done in a call to nvml.Init().
//
// Deprecated: LookupSymbol represents an unstable API and should be considered experimental.
func LookupSymbol(name string) error {
if nvml == nil {
return fmt.Errorf("error looking up %s: library %s not initialized", name, nvmlLibraryName)
}
return nvml.Lookup(name)
}