Add top-level function to lookup symbols #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
add-symbol-lookup
branch
from
0bc2a5e to
5341002
Compare
This change adds a top-level LookupSymbol function. This replaces the need to explicitly open a library locally and check the symbols there in clients of these bindings. Note that this API is considered experimental. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
add-symbol-lookup
branch
from
5341002 to
1ef2d1f
Compare
klueska
reviewed
Oct 16, 2023
Comment on lines
+25
to
+30
| func LookupSymbol(name string) error { | ||
| if nvml == nil { | ||
| return fmt.Errorf("error looking up %s: library %s not initialized", name, nvmlLibraryName) | ||
| } | ||
| return nvml.Lookup(name) | ||
| } |
There was a problem hiding this comment.
Does it make more sense to provide a function that just returns the nvml library itsself and then allow them to call Lookup() on that (or whatever other operation we may have on the DynamicLibrary type in the future)?
elezar
added a commit
that referenced
this pull request
Oct 17, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Merged
elezar
added a commit
that referenced
this pull request
Oct 17, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 17, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 18, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 19, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 19, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 19, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 19, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 19, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 20, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
added a commit
that referenced
this pull request
Oct 20, 2023
This change reworks the Lookup function added in #84. It adds an Interface type at a top level with functionality in an interface. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a top-level LookupSymbol function. This replaces the need to explicitly open a library locally and check the symbols there in clients of these bindings.
Note that this API is considered experimental.