-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content] Spring 2024 tornado season data story #420
Conversation
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@acblackford I'm going through and testing now, since it's short notice I'll post this comment now before I'm done testing. First thing I notice is that all the datasets could use an See the recent PR for NLDAS for an example. #498 My suggestion would be to use the bulleted list of "Dataset Details" that you have in the body of each dataset mdx file already. |
@acblackford the only other thing that I notice is that the email link at the bottom probably is not functioning as intended. It just opens a page with mailto appended at the end of the URL. I actually see recent stories with it, like Black Belt, also behaving this way. Off the top of my head I'm not sure how to solution this, or if we have encountered this in the past. Do you have any ideas? Maybe for a short term solution we just remove it as a link? |
@aboydnw All datasets should now have info descriptions added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you creating this Pull Request?