Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset): add ps-greenfield-post-tornadoes-2024 dataset config #204

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

anayeaye
Copy link
Contributor

@anayeaye anayeaye commented Dec 2, 2024

What

Add stac collection and ingestion config for ps-greenfield-post-tornadoes-202

Parent issue

#187

Downstream veda-config PR

NASA-IMPACT/veda-config#420

Checklist

  • align title and description with veda-config
  • staging config completed and verified
  • published to staging
  • transfer config and production metadata updated
  • published to production

Comment on lines 69 to 81
"renders": {
"dashboard": {
"resampling": "bilinear",
"bidx": "cog_default|1,2,3",
"nodata": null,
"assets": [
"cog_default"
],
"rescale": [[0, 255]],
"title": "VEDA Dashboard Render Parameters"
}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smohiudd I'm having trouble configuring renders for this collection. This produces a bad preview https://staging.openveda.cloud/api/raster/collections/ps-greenfield-post-tornadoes-2024/items/Planet_Greenfield_After_cog_2024-05-22/preview.png?bidx=cog_default%7C1%2C2%2C3&assets=cog_default&nodata=None&rescale=0%2C255&resampling=bilinear

veda-config params are

    sourceParams:
      rescale:
        - 0,255
      resampling: bilinear
      asset_bidx: cog_default|1,2,3

Copy link
Contributor Author

@anayeaye anayeaye Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the goal
https://staging.openveda.cloud/api/raster/collections/ps-greenfield-post-tornadoes-2024/items/Planet_Greenfield_After_cog_2024-05-22/preview.png?assets=cog_default&rescale=0,255&resampling=bilinear&asset_bidx=cog_default|1,2,3

I took out the nodata in the renders config and now have a slightly more helpful error message. I think the fix may be in the backend? We can move forward with the other ingests first
https://staging.openveda.cloud/api/raster/collections/ps-greenfield-post-tornadoes-2024/items/Planet_Greenfield_After_cog_2024-05-22/preview.png?bidx=cog_default%7C1%2C2%2C3&assets=cog_default&rescale=0%2C255&resampling=bilinear

{
  "detail": [
    {
      "type": "int_parsing",
      "loc": [
        "query",
        "bidx",
        0
      ],
      "msg": "Input should be a valid integer, unable to parse string as an integer",
      "input": "cog_default|1,2,3"
    }
  ]
}

Copy link
Contributor Author

@anayeaye anayeaye Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for this right now is to use assets + bidx=[1,2,3] instead of bidx=cog_default|1,2,3. I will open an issue to look into the pipe notation but this renders config works for the collection

"renders": {
        "dashboard": {
            "resampling": "bilinear",
            "bidx": [1,2,3],
            "assets": [
                "cog_default"
            ],
            "rescale": [[0, 255]],
            "title": "VEDA Dashboard Render Parameters"
        }
    }

@anayeaye anayeaye merged commit 26bdb5f into main Dec 6, 2024
2 checks passed
@anayeaye anayeaye deleted the feat/ps-greenfield-post-tornadoes-2024-20241202 branch December 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants