Redesign local nav for GDT #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7849907042
💛 - Coveralls |
jazairi
force-pushed
the
gdt-125-redesign-local-nav
branch
from
46f6875 to
28288fe
Compare
JPrevost
approved these changes
Feb 8, 2024
jazairi
force-pushed
the
gdt-125-redesign-local-nav
branch
from
28288fe to
97f1858
Compare
9 tasks
|
@jazairi Just confirming this is still good with the latest change and can merge whenever you are ready along with the related PR |
|
Thanks @JPrevost! Just waiting on QA before merging. |
|
@JPrevost Just pushed a couple of small changes from QA. I also added the nav title back in (conditionally) to stay consistent with how we plan to manage that for the time being. |
JPrevost
approved these changes
Feb 9, 2024
Why these changes are being introduced: The Geodata app requires links to GIS resources at MIT in the local nav. It also no longer requires the app name in the local nav, as GDT-125 moved this to the main header. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-125 * https://mitlibraries.atlassian.net/browse/GDT-124 How this addresses that need: This restyles the local nav as specified, provided the GDT feature is enabled. It also makes the title in the nav conditional on whether the `PLATFORM_NAME` environment variable is present. (This toggles the name in the header.) Side effects of this change: None.
jazairi
force-pushed
the
gdt-125-redesign-local-nav
branch
from
18e3296 to
e927c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The Geodata app requires links to GIS resources at MIT in the local nav. It also no longer requires the app name in the local nav, as GDT-125 moved this to the main header.
Relevant ticket(s):
How this addresses that need:
This updates the local nav as specified, provided the GDT feature is enabled.
Side effects of this change:
We will likely want to remove the app name from the local nav in all our applications and use the new method provided by the theme gem instead. However, it is out of scope of this ticket (and project) to make that decision, so I've left it in for now.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO