Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme gem and document PLATFORM_NAME variable #114

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Feb 9, 2024

Why these changes are being introduced:

The GDT project added a feature to the theme gem to conditionally include the platform name in the header if the PLATFORM_NAME environment variable is supplied.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-124

How this addresses that need:

This updates the theme gem to the v1.2 tag, which includes the new feature, and documents the PLATFORM_NAME variable.

Side effects of this change:

None. The app will continue to use the standard header if PLATFORM_NAME is not supplied.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to timdex-ui-pi-gdt-124-pl-xzfa7e February 9, 2024 14:25 Inactive
@coveralls
Copy link

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 7845471351

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.444%

Totals Coverage Status
Change from base Build 7835420707: 0.0%
Covered Lines: 358
Relevant Lines: 360

💛 - Coveralls

Why these changes are being introduced:

The GDT project added a feature to the theme gem to conditionally
include the platform name in the header if the `PLATFORM_NAME`
environment variable is supplied.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-124

How this addresses that need:

This updates the theme gem to the v1.2 tag, which includes the new
feature, and documents the PLATFORM_NAME variable.

Side effects of this change:

None. The app will continue to use the standard header if
PLATFORM_NAME is not supplied.
@jazairi jazairi force-pushed the gdt-124-platform-name-in-header branch from 23fa9e9 to cfaf80b Compare February 9, 2024 14:35
@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-124-pl-xzfa7e February 9, 2024 14:36 Inactive
@jazairi
Copy link
Contributor Author

jazairi commented Feb 9, 2024

Note to reviewer that the TIMDEX UI title in the local nav will be removed in #113.

Copy link
Member

@JPrevost JPrevost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform name seems slightly misaligned to me in the smallest viewports, but that is a theme gem thing that we can loop back to in the future.

edit (also, it just looks misaligned to me. I don't think it actually is which is of course more fun)

@jazairi jazairi merged commit b2c8911 into main Feb 9, 2024
5 checks passed
@jazairi jazairi deleted the gdt-124-platform-name-in-header branch February 9, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants