Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProQuest consent field from receipt email #1407

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Dec 20, 2024

Why these changes are being introduced:

We removed the ProQuest consent field from the thesis submission form, but forgot to remove the field from the mailer. Thus, when a grad student submits their thesis, they see this nonexistent field in their confirmation email.

Relevant ticket(s):

N/A

How this addresses that need:

This removes the field from the mailer.

Side effects of this change:

None.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

We removed the ProQuest consent field from the thesis submission
form, but forgot to remove the field from the mailer. Thus, when
a grad student submits their thesis, they see this nonexistent
field in their confirmation email.

Relevant ticket(s):

N/A

How this addresses that need:

This removes the field from the mailer.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to thesis-submit-pr-1407 December 20, 2024 18:44 Inactive
@coveralls
Copy link

Coverage Status

coverage: 98.313%. remained the same
when pulling 095f158 on remove-proquest-from-email
into 679165e on main.

@matt-bernhardt matt-bernhardt self-assigned this Dec 20, 2024
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the tests passing, and I see the updated test is the same format used to confirm that undergraduates aren't seeing the (now-removed) message - so this seems fine for me.

I have not confirmed the mailer itself locally, but the change to the template seems straightforward enough to be reviewable without it. The sentence we want to be removed is just gone.

:shipit:

@jazairi jazairi merged commit fb03c2e into main Dec 20, 2024
3 checks passed
@jazairi jazairi deleted the remove-proquest-from-email branch December 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants