Skip to content

Commit

Permalink
Merge pull request #1407 from MITLibraries/remove-proquest-from-email
Browse files Browse the repository at this point in the history
Remove ProQuest consent field from receipt email
  • Loading branch information
jazairi authored Dec 20, 2024
2 parents 679165e + 095f158 commit fb03c2e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 0 additions & 3 deletions app/views/receipt_mailer/receipt_email.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ The information we have on record is listed below.</p>
<strong>Abstract:</strong><br>
<%= simple_format(@thesis.abstract, {}, wrapper_tag: "p") %>
<strong>Notes:</strong> <%= @thesis.author_note %><br>
<% if satisfies_advanced_degree?(@thesis) %>
<strong>Consent to send thesis to ProQuest:</strong> <%= render_proquest_status(@thesis) %>
<% end %>
</div>

<p>Let us know if you have any questions. And again, congratulations
Expand Down
6 changes: 4 additions & 2 deletions test/mailers/receipt_mailer_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ class ReceiptMailerTest < ActionMailer::TestCase
end
end

test 'confirmation emails for graduate theses include ProQuest consent' do
# This used to be a test that the emails _do_ include ProQuest consent, but we removed that feature in December 2024.
# This test is to ensure that grad students do not see a nonexistent metadata field in their receipt email.
test 'confirmation emails for graduate theses do not include ProQuest consent' do
ClimateControl.modify DISABLE_ALL_EMAIL: 'false' do
thesis = theses(:doctor)
user = users(:basic)
Expand All @@ -29,7 +31,7 @@ class ReceiptMailerTest < ActionMailer::TestCase
email.deliver_now
end

assert_match '<strong>Consent to send thesis to ProQuest:</strong> Opt-in status not reconciled', email.body.to_s
refute_match '<strong>Consent to send thesis to ProQuest:</strong>', email.body.to_s
end
end

Expand Down

0 comments on commit fb03c2e

Please sign in to comment.