-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a11y-alt-text bot #989
feat: add a11y-alt-text bot #989
Conversation
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
==========================================
+ Coverage 93.57% 93.61% +0.04%
==========================================
Files 92 92
Lines 4921 4952 +31
Branches 413 413
==========================================
+ Hits 4605 4636 +31
Misses 315 315
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this in @DerTimonius! Quoting #825 (comment):
I'll want to see examples of the bot in another repository that you've set up with the latest version of the bot. I'd suggest using this template to make a new repository.
In other words: could you please show this working in a repo you've created? It'll help reviewing to have us both play with it.
Also, note that you've got failures in CI. See the .github/DEVELOPMENT.md
file for how to resolve them. Or let me know if that's unclear. Cheers!
Sure, I added it to a repo of mine and opened an issue with images with missing alt texts: DerTimonius/til-blog#7 Edit: currently working on fixing the failing test |
Tests are fixed now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right almost forgot - this'll need to be added to the workflows.ts
file and its corresponding test. Otherwise this won't be added to created/templated repos.
@JoshuaKGoldberg I added the bot to the created files (good idea, did not think about that) - had to change a few types along the way. Also I added the .yml file to the |
Mmhh yeah it's the other way around: the files in the repo should match the templates. I'd like to whittle that list down of "these are intentionally different" to zero over time. Change request: have the |
@JoshuaKGoldberg The latest change also changes the location of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯. I suspect the if
isn't necessary, but that feels like a suggestion to make on the accessibility-alt-text-bot repo. I can file that over there #997.
Otherwise, yeah, this is looking wonderful. Thanks! 🚀
🎉 This is included in version v1.41.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
This PR adds a new bot to check for alt text in issue, PR or discussion comments.
With the .yml file, I followed the suggestion in the official repo and adapted the used version to the latest version.