Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Is the 'if' in the accessibility-alt-text-bot workflow is needed? #997

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 30, 2023 · 5 comments · Fixed by #1009
Closed
3 tasks done

🛠 Tooling: Is the 'if' in the accessibility-alt-text-bot workflow is needed? #997

JoshuaKGoldberg opened this issue Oct 30, 2023 · 5 comments · Fixed by #1009
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Following up on @DerTimonius's #989 (comment): we merged the PR with the if:

create-typescript-app/.github/workflows/accessibility-alt-text-bot.yml

Line 5 in 0558e97

- if: ${{ github.event.issue || github.event.pull_request }}

...but I'm not sure that it's necessary. Are there events from GitHub's on.(issue|issue_comment|pull_request) that don't have github.event.issue || github.event.pull_request?

Additional Info

This feels like something someone could probably answer by looking at the docs and/or experimenting in a temporary repository. But I haven't had the time to try. 😄

Marking as status: accepting prs in case the answer is that the if is unnecessary. But if it is necessary, the right solution would be to close and wontfix this issue.

cc @kendallgassner as fyi / for visibility if you're curious
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Oct 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 30, 2023
Merged
3 tasks
@kendallgassner
Copy link

Oh good point! I think this might be fallout from a refactor i'll file a bug on our end to check it out.

@kendallgassner kendallgassner mentioned this issue Oct 30, 2023
Closed
3 tasks
@DerTimonius
Copy link
Contributor

I tried removing the if in a test repo, but there was no comment by the bot on this issue. So apparently it is necessary.

@kendallgassner
Copy link

This was surprising to me so I tested it on my end. I realized the README was out of date and if we bump to the latest version: 1.4.0 we do not need the if.

@DerTimonius DerTimonius mentioned this issue Nov 5, 2023
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

Awesome thanks!

JoshuaKGoldberg pushed a commit that referenced this issue Nov 5, 2023
@DerTimonius
chore: remove unnecessary if in a11y-alt-bot (#1009)
69af9ec 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [X] Addresses an existing open issue: fixes #997
- [X] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [X] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

This PR is hopefully the last one in the series of getting the
`accessibility-alt-text-bot` correct by removing the unnecessary `if`
statement in the `yml` job
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

🎉 This is included in version v1.43.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove unnecessary if in a11y-alt-bot DerTimonius/create-typescript-app
3 participants
@JoshuaKGoldberg @kendallgassner @DerTimonius