Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedestrian pipes #143

Merged
merged 31 commits into from
May 13, 2024
Merged

Pedestrian pipes #143

merged 31 commits into from
May 13, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Apr 29, 2024

Description

  • It is common(ish) for pipes to not be under roads and instead along walkways. This method downloads the walking network and composes it with the drive network.
  • A user may specify allowable network_type in topology_derivation.allowable_networks. The downloader (prepare_data.download_street) retrieves and composes all of these.
  • Only the drive network is assumed to contribute to impervious area and so have others lanes set to 0.

Other changes:

  • If verbosity is enabled, graph geojsons are saved after every graphfcn (this has been massively helpful for debug).
  • Some other various small tidying/bug fixing.

Discussion points:

  • We might not want all pedestrian networks to be considered, as this will potentially put a lot of pipes and manholes in dumb locations. The only simple solution I can think of would be to add some weight parameter to these networks to avoid them if possible, but it doesn't feel very satisfying. @cheginit - wonder if you have any thoughts on this? - now in Remove nodes that are likely not part of the network #161
  • The naming conventions are now a bit confusing - download_street can download any network_type (including walk and cycle), and the edge_type of any downloaded network that isn't a river is given the tag street (i.e., indicating it can have a pipe under it. I propose to replace the keyword street with network, so it would be come download_network and edge_type=network. - now in Naming convention of street -> network #162

Fixes #128

Dobson added 2 commits April 29, 2024 14:00
avoid double counting
Improve efficiency of area calc
@barneydobson barneydobson linked an issue Apr 29, 2024 that may be closed by this pull request
@barneydobson barneydobson requested review from dalonsoa and removed request for dalonsoa May 9, 2024 15:40
@barneydobson barneydobson requested review from cheginit and dalonsoa May 9, 2024 15:40
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a couple of comments and suggestions. Otherwise, I see significant amount of code changed, but no new tests added or updated...

swmmanywhere/graph_utilities.py Show resolved Hide resolved
swmmanywhere/graph_utilities.py Show resolved Hide resolved
swmmanywhere/graph_utilities.py Show resolved Hide resolved
swmmanywhere/preprocessing.py Outdated Show resolved Hide resolved
@barneydobson barneydobson merged commit c4da7d3 into main May 13, 2024
10 checks passed
@barneydobson barneydobson deleted the 128-pipes-not-under-roads branch May 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipes not under roads
2 participants