generated from ImperialCollegeLondon/pip-tools-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pedestrian pipes #143
Merged
Merged
Pedestrian pipes #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid double counting
Improve efficiency of area calc
Closed
widen to prevent outlet nonsense
more verbosity
deprecation error
make float
merge only street nodes
Fix new double_directed
another bug
remove old change
This reverts commit b347dbf.
dalonsoa
requested changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a couple of comments and suggestions. Otherwise, I see significant amount of code changed, but no new tests added or updated...
fix merge
This reverts commit f0b4c17.
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
network_type
intopology_derivation.allowable_networks
. The downloader (prepare_data.download_street
) retrieves and composes all of these.drive
network is assumed to contribute to impervious area and so have otherslanes
set to 0.Other changes:
Discussion points:
download_street
can download anynetwork_type
(includingwalk
andcycle
), and theedge_type
of any downloaded network that isn't a river is given the tagstreet
(i.e., indicating it can have a pipe under it. I propose to replace the keywordstreet
withnetwork
, so it would be comedownload_network
andedge_type=network
. - now in Naming convention ofstreet
->network
#162Fixes #128