Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention of street -> network #162

Open
barneydobson opened this issue May 13, 2024 · 0 comments
Open

Naming convention of street -> network #162

barneydobson opened this issue May 13, 2024 · 0 comments
Labels

Comments

@barneydobson
Copy link
Collaborator

barneydobson commented May 13, 2024

The naming conventions are now a bit confusing - download_street can download any network_type (including walk and cycle), and the edge_type of any downloaded network that isn't a river is given the tag street (i.e., indicating it can have a pipe under it. I propose to replace the keyword street with network, so it would be come download_network and edge_type=network.

Originally posted in #143 by @barneydobson

Any link that can carry a pipe should be referred to as network - thus most instances of the software that refer to a street (the keyword previously used) should be changed to network - unless it is explicitly referring to a street (e.g., presumably in the downloader and streetcover calculation)

@barneydobson barneydobson added the good first issue Good for newcomers label Jul 29, 2024
@barneydobson barneydobson changed the title Naming convention of street -> pipe Naming convention of street -> network Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant