Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlyne: update test to remove expect dependency #202603

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Dec 28, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Dec 28, 2024
@cho-m cho-m marked this pull request as ready for review December 28, 2024 01:02
@cho-m
Copy link
Member Author

cho-m commented Dec 29, 2024

Maybe rendering doesn't work on Intel runners.

Will probably try dumping the logs to stdout to see what is happening.

The original test really just started and killed after timeout as inlyne runs in a separate window so key presses don't work (i.e. send -- "q\r" didn't do anything)

@cho-m cho-m marked this pull request as draft January 3, 2025 03:13
@cho-m
Copy link
Member Author

cho-m commented Jan 3, 2025

INFO wgpu_hal::gles::egl: Unable to open libEGL:
Library(DlOpen { desc: \"dlopen(libEGL.dylib, 0x0005): tried: 
\\'libEGL.dylib\\' (no such file),
\\'/System/Volumes/Preboot/Cryptexes/OSlibEGL.dylib\\' (no such file),
\\'/usr/lib/libEGL.dylib\\' (no such file, not in dyld cache),
\\'libEGL.dylib\\' (no such file),
\\'/usr/local/lib/libEGL.dylib\\' (no such file),
\\'/usr/lib/libEGL.dylib\\' (no such file, not in dyld cache)\" })

EDIT: Though it should have tried another option like Metal afterward. May be problem limitation in runner.

@cho-m cho-m force-pushed the inlyne-test branch 2 times, most recently from b29171b to e3f09b7 Compare January 17, 2025 01:59
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 17, 2025
@cho-m cho-m force-pushed the inlyne-test branch 5 times, most recently from 4a9f618 to bdaec1c Compare January 17, 2025 05:25
@cho-m cho-m added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. and removed CI-no-bottles Merge without publishing bottles labels Jan 17, 2025
@cho-m cho-m force-pushed the inlyne-test branch 2 times, most recently from 1810e3d to c81151a Compare January 17, 2025 15:48
@cho-m
Copy link
Member Author

cho-m commented Jan 17, 2025

For Linux, added a fontconfig workaround which seems to at least help find some fonts now:

  2025-01-17T16:46:39.477317Z  INFO cosmic_text::font::system::std: Parsed 6 font faces in 0ms.   

However, seems like one of required fonts is not found. Not sure why cosmic_text isn't using DejuVu Sans which I think is installed.

  2025-01-17T16:46:39.599506Z TRACE cosmic_text::shape: Line LTR: 'lorem ipsum dolor sit amet'    
  2025-01-17T16:46:39.599509Z TRACE cosmic_text::shape:   Span LTR: 'lorem ipsum dolor sit amet'    
  2025-01-17T16:46:39.599512Z TRACE cosmic_text::shape:       Word: 'lorem'    
  2025-01-17T16:46:39.599514Z TRACE cosmic_text::shape:       Run []: ''    
  2025-01-17T16:46:39.599519Z DEBUG cosmic_text::font::system::std: font matches for Attrs { color_opt: Some(Color(4278190080)), family: SansSerif, stretch: Normal, style: Italic, weight: Weight(400), metadata: 0 } in 871ns    
  2025-01-17T16:46:39.599524Z DEBUG cosmic_text::font::fallback: failed to find family 'Noto Sans'    
  2025-01-17T16:46:39.599526Z DEBUG cosmic_text::font::fallback: failed to find family 'DejaVu Sans'  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant