Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Escargot engine #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clover2123
Copy link
Contributor

  • newly add a JavaScript engine called Escargot

Note:
Escargot is a lightweight JavaScript engine developed by Samsung, designed specifically for resource-constrained environments.

@clover2123 clover2123 mentioned this pull request Nov 26, 2024
@mathiasbynens
Copy link
Member

Testing this locally on mac64arm, I get:

$ node cli.js --engines=escargot
📦 jsvu v2.4.1 — the JavaScript engine Version Updater 📦
✔ Read OS from config: mac64arm
✔ Read engines from config: escargot
✔ Found latest Escargot version: v4.2.0.
✔ URL: https://github.com/Samsung/escargot/releases/download/v4.2.0/escargot-mac64arm.zip
✔ Download completed.
❯ Extracting…
Installing library to ~/.jsvu/engines/escargot/libicudata.76.1.dylib…
Installing library to ~/.jsvu/engines/escargot/libicudata.76.dylib…
Installing library to ~/.jsvu/engines/escargot/libicui18n.76.1.dylib…
Installing library to ~/.jsvu/engines/escargot/libicui18n.76.dylib…
Installing library to ~/.jsvu/engines/escargot/libicuuc.76.1.dylib…
Installing library to ~/.jsvu/engines/escargot/libicuuc.76.dylib…
Installing binary to ~/.jsvu/engines/escargot/escargot…
Installing symlink at ~/.jsvu/bin/escargot pointing to ~/.jsvu/engines/escargot/escargot…
✔ Extraction completed.
❯ Testing…
✖ Error: Command failed with exit code 137 (Unknown system error -137): ~/.jsvu/bin/escargot /private/var/folders/4b/k028f6wj3gjdt155k431t8cm00fj2f/T/b87ca986a23fb47a9746d949110bc70f

Could you please take a look?

Signed-off-by: HyukWoo Park <hyukwoo.park@samsung.com>
@clover2123
Copy link
Contributor Author

When I run this patch on macos-14, it passed as below.
(also run in actions: https://github.com/clover2123/jsvu/actions/runs/12031833089/job/33542249167)

I'm not sure what the problem actually is :(

$ node cli.js --os=mac64arm --engines=escargot
📦 jsvu v2.[4](https://github.com/clover2123/jsvu/actions/runs/12031833089/job/33542249167#step:4:5).1 — the JavaScript engine Version Updater 📦
✔ Read OS from config: mac64arm
✔ Read engines from config: escargot
❯ Finding the latest Escargot version…
✔ Found latest Escargot version: v4.2.0.
❯ Predicting URL…
✔ URL: https://github.com/Samsung/escargot/releases/download/v4.2.0/escargot-mac[6](https://github.com/clover2123/jsvu/actions/runs/12031833089/job/33542249167#step:4:7)4arm.zip
❯ Downloading…


✔ Download completed.
❯ Extracting…
Installing library to ~/.jsvu/engines/escargot/libicudata.[7](https://github.com/clover2123/jsvu/actions/runs/12031833089/job/33542249167#step:4:8)6.1.dylib…
Installing library to ~/.jsvu/engines/escargot/libicudata.76.dylib…
Installing library to ~/.jsvu/engines/escargot/libicui1[8](https://github.com/clover2123/jsvu/actions/runs/12031833089/job/33542249167#step:4:9)n.76.1.dylib…
Installing library to ~/.jsvu/engines/escargot/libicui18n.76.dylib…
Installing library to ~/.jsvu/engines/escargot/libicuuc.76.1.dylib…
Installing library to ~/.jsvu/engines/escargot/libicuuc.76.dylib…
Installing binary to ~/.jsvu/engines/escargot/escargot…
Installing symlink at ~/.jsvu/bin/escargot pointing to ~/.jsvu/engines/escargot/escargot…
✔ Extraction completed.
❯ Testing…
✔ Testing completed.
✔ Escargot v4.2.0 has been installed! 🎉

@clover2123
Copy link
Contributor Author

clover2123 commented Nov 26, 2024

Could you check by running the following command in your local environment?
If escargot were installed correctly, then it would run without any errors.

echo 'print("hello world!");' > test.js
~/.jsvu/bin/escargot test.js  // this should print `hello world!`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants