Add Escargot

[clover2123]

Hi all!

I would like to support our lightweight, cross-platform JavaScript engine Escargot for jsvu.
Currently, Escargot enables compatibility across multiple platforms - including Linux, macOS, and Windows - while maintaining full compliance with the most recent ECMAScript standard, specifically ECMAScript 2024.
Would it be possible for us to discuss further regarding this matter?

[mathiasbynens]

Happy to review a patch :)

[clover2123]

Could you provide me with some references to begin with or follow to assist in adding our JavaScript engine for jsvu?

[mathiasbynens]

Look at the engines folder, pick an example, and use it as a starting point: https://github.com/GoogleChromeLabs/jsvu/tree/main/engines

[clover2123]

@mathiasbynens
Would you please review my patch #150 ?

[mathiasbynens]

Closed by #150. Thanks for the patch!

[mathiasbynens]

This doesn’t work on macOS yet:

$ ./cli.js --engines=escargot
📦 jsvu v2.4.0 — the JavaScript engine Version Updater 📦
✔ Read OS from config: mac64arm
✔ Read engines from config: escargot
✔ Found latest Escargot version: v4.2.0.
✔ URL: https://github.com/Samsung/escargot/releases/download/v4.2.0/escargot-mac64arm
✔ Download completed.
❯ Extracting…
Installing binary to ~/.jsvu/engines/escargot/escargot…
Installing symlink at ~/.jsvu/bin/escargot pointing to ~/.jsvu/engines/escargot/escargot…
Installing wrapper script to ~/.jsvu/bin/escargot…
✔ Extraction completed.
❯ Testing…
✖ Error: Command failed with exit code 134 (Unknown system error -134): ~/.jsvu/bin/escargot /private/var/folders/4b/k028f6wj3gjdt155k431t8cm00fj2f/T/7ff754efc58f7cd0b1aac403eab70fde

Here’s the output when trying to run the binary directly:

$ ~/.jsvu/bin/escargot
dyld[95968]: Library not loaded: /opt/homebrew/opt/icu4c@75/lib/libicui18n.75.dylib
  Referenced from: <DE20FEF1-53F4-3CF0-8976-F30090C4973F> ~/.jsvu/engines/escargot/escargot
  Reason: tried: '/opt/homebrew/opt/icu4c@75/lib/libicui18n.75.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/icu4c@75/lib/libicui18n.75.dylib' (no such file), '/opt/homebrew/opt/icu4c@75/lib/libicui18n.75.dylib' (no such file)
~/.jsvu/bin/escargot: line 2: 95968 Abort trap: 6           "~/.jsvu/engines/escargot/escargot" "$@"

It looks like you’ll need to bundle the required *.dylib files, and then install them like here:

jsvu/engines/v8-debug/extract.js

Line 38 in 15ed030

installer.installLibraryGlob('*.dylib');

Currently the generated download URL points to an executable file. I’d suggest to publish ZIP files for each release containing not only the binary but also its dependencies, matching what other engine providers do.

[mathiasbynens]

Once all that is addressed, we’ll also need to update https://github.com/GoogleChromeLabs/jsvu#supported-engines-per-os to list Escargot.

[mathiasbynens]

I’ve backed out the initial PR in beff883. Please address the TODOs in #147 (comment) and send a new patch.

[clover2123]

@mathiasbynens
Sure! thanks for the review. I'll update the patch soon :)

[clover2123]

@mathiasbynens
I've uploaded #152 that also handles shared libraries.
Please review this