-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build #124
Conversation
- dropped python 3.9 support [in version 0.23](scikit-image/scikit-image@4841d53) - dropped python 3.8 support [in version 0.22](scikit-image/scikit-image@21cdcfe#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711) - see [scientific python specs](https://scientific-python.org/specs/spec-0000/) for motivation/reasoning for these drops.
- matplotlib dropped python 3.8 [in version 3.8](matplotlib/matplotlib@e2a2a87)
- doesn't seem to be used anywhere - was first introduced with the kirsch operator but doesn't seem like that function relies on pillow
- pywavelets is a dependency of scikit-image, which: - dropped python 3.9 support in [version 1.6.0](PyWavelets/pywt@734ef4b) - dropped python 3.8 support in [version 1.5.0](PyWavelets/pywt@0a24ebc#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711)
- contourpy dropped python 3.8 support [in version 1.2.0](contourpy/contourpy@2b0a1a9)
@bethac07 The >13K lines deleted is just from removing The The main thing to pay attention to is the changes to Eventually, as we will want to support python 3.10 and later in CP5, we will have to bump centrosome and have two branches, one specifically for the |
- do not matrix across python version as it already does this internally - do not pip install packages as it already does this internally - restrict python versions in pyproject.toml
- letting cibuildwheel handle the python version matrixing breaks - manually doing it and the dependency resolution gives more fine grained control - modeled after scikit-image: https://github.com/scikit-learn/scikit-learn/blob/7eb7effae192f8fa9e29e14507970f5a7da6088c/.github/workflows/wheels.yml
Resolves CellProfiler/CellProfiler#4906