-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize second batch of Resources tests #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tests fails consistently using CADASTA_TEST_WEBDRIVER=Firefox
@@ -566,6 +851,66 @@ def test_file_with_nonacceptable_mime_type_cannot_be_uploaded( | |||
'//*[contains(@class, "file-well")]' | |||
'//*[normalize-space()="File type not allowed."]') | |||
|
|||
@pytest.mark.uploads | |||
def test_multiple_existing_resources_from_different_pages_can_be_attached( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails with selenium.common.exceptions.WebDriverException: Message: Failed to decode response from marionette
.
Following that there's another error during tear down (ERROR at teardown of TestAttaching.test_multiple_existing_resources_from_different_pages_can_be_attached
): selenium.common.exceptions.SessionNotCreatedException: Message: Tried to run command without establishing a connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be solved by increasing the VM's RAM to 3GB. When I'm running the test with the default 2GB, I consistently get the WebDriverException
error. This goes away when I increased the size to 3GB. I noticed this because the test didn't fail when run on Travis and this is the longest test we have (so far) because of the need to set up and then clean up 11 resource files, which implies that the test needs more computing resources. I have no idea why there is no out-of-memory error message or something that appears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in our call, try to use fixtures instead of uploading all the files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've add a commit to the branch to remove the 11 dummy resources and replace them with 11 test fixture objects of model resources.resource
and updated the test to match.
583bd44
to
b4a6fb5
Compare
Proposed changes in this pull request
Add automated functional tests for the remaining Resources test cases as described in the Functional Test Cases spreadsheet:
0.6.0
.When should this PR be merged
When convenient.
Risks
No risks foreseen. This PR should only affect QA and not the actual platform function.
Follow-up actions
Release then update cadasta-platform.
Checklist (for reviewing)
General
migration
label if a new migration is added.Functionality
Code
Tests
Security
Documentation