Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent test error and implement Forms test case #X8 #84

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

seav
Copy link
Contributor

@seav seav commented Feb 21, 2018

Proposed changes in this pull request

Why:

What:

  • Bump package version to 0.6.1 (assumes Finalize second batch of Resources tests #83 is merged first).
  • Add new test for Forms test case #X8. Previously this test case expected a 500 error but now uploading an XLSForm with resource types inside a group should now be accepted. Also update the corresponding XLSForm test file so that image, audio, and video types are included in groups.
  • Fix intermittent test error by reloading the project creation wizard for each sub-test case. The intermittent error seems to occur due to a hard-to-track interaction with the client-side JS validation of form fields.
  • Update runtests.py script to avoid the Django ImproperlyConfigured error. This mirrors the change in Include cadasta app in Python path cadasta-platform#1889. This repo-local runtests.py script is actually an alternate way to run functional tests in the Dev VM and allows greater control than running ./runtests.py --functional in the cadasta-platform repo.

When should this PR be merged

Preferably after #83.

Risks

None foreseen.

Follow-up actions

Release then update cadasta-platform.

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly? It should have the migration label if a new migration is added.
  • Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

@seav seav requested a review from oliverroick February 21, 2018 03:04
@seav seav changed the title Fix intermittent error; add Forms test Fix intermittent test error and implement Forms test case #X8 Feb 21, 2018
@oliverroick oliverroick merged commit 3fd12e9 into master Feb 28, 2018
@oliverroick oliverroick deleted the fix-intermittent-and-add-form-test branch February 28, 2018 19:13
@seav seav added the PR: bugfix label Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add test for resource fields in question groups
2 participants