Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller #10

Merged
merged 15 commits into from
Jan 8, 2025
Merged

Controller #10

merged 15 commits into from
Jan 8, 2025

Conversation

mehulgoel873
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Describe the CHANGES, the REASONING, and BENEFITS of this PR.
CHANGES - Seperated controller from path planner and converted to ROS 2
REASONING - Allowed for greater control of buggies to navigate and be useful
BENEFITS - We can now have path planning buggies or not, and additional communication

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

Copy link

@TiaSinghania TiaSinghania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor concerns + notes on the todos left in code

.gitignore Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/util/pose.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/util/trajectory.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/util/trajectory.py Show resolved Hide resolved
rb_ws/src/buggy/buggy/controller/controller_node.py Outdated Show resolved Hide resolved
@TiaSinghania TiaSinghania merged commit 7c3cb77 into main Jan 8, 2025
3 checks passed
@TiaSinghania TiaSinghania deleted the controller branch January 8, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants