Pin container image digests #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes surprise changes if a tag is updated. Pinning digests requires that handling these updates must be done (manually or automatically) in the repo, instead of silently occuring on end devices. This should allow for more transparent debugging if we do run into an issue. * Prevents cache invalidation when an image is updated. OSRF pushes new updates to our ROS image regularly, invalidating our cache. (https://hub.docker.com/layers/osrf/ros/noetic-desktop-full-focal/images/sha256-9b846bfafa51e85d25c0c482994b558318071d5ffd1800747c07dd3ba17c362b?context=explore) * Preserves docker metadata cache so it does not attempt to refresh it every time we run the project. Future steps: * Set a policy for updating pins and configure renovate or dependabot to assist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Removes surprise changes if a tag is updated. Pinning digests requires that handling these updates must be done (manually or automatically) in the repo, instead of silently occuring on end devices. This should allow for more transparent debugging if we do run into an issue.
Prevents cache invalidation when an image is updated. OSRF pushes new updates to our ROS image regularly, invalidating our cache. (https://hub.docker.com/layers/osrf/ros/noetic-desktop-full-focal/images/sha256-9b846bfafa51e85d25c0c482994b558318071d5ffd1800747c07dd3ba17c362b?context=explore)
Preserves docker metadata cache so it does not attempt to refresh it every time we run the project.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
Manual testing is required to determine if this resolves the metadata issue.
Existing automated testing should cover these changes going forward.
Are there any post deployment tasks we need to perform?
When you pull the repository, always build or start the compose project while you still have internet. If you know you will not be able to this, PRs that update pinned digests should not be merged until this is possible.
Future Steps