Revert node engine change (#1002)

Blizzard · Jan 25, 2023 · 9ffc9c6 · 9ffc9c6
1 parent aba2011
commit 9ffc9c6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,7 +10,7 @@ jobs:
   build:
     strategy:
       matrix:
-        node: [14, 16, 18, 19]
+        node: [10, 12, 14, 16, 18, 19]
         os: [ubuntu-22.04]
         include:
           # single mac test due to minute multipliers
@@ -30,12 +30,14 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
           cache: "npm"
+      - name: Update node-gyp
+        run: npm install --global node-gyp@latest
       - name: Install Windows packages
         if: runner.os == 'Windows'
         run: ./win_install.ps1
       - name: Build
         run: npm ci
       # skipping on windows for now due to Make / mocha exit code issues
       - name: Test
-        if: runner.os != 'Windows'
+        if: runner.os != 'Windows' && matrix.node != 10
         run: npm test
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "node-rdkafka",
-  "version": "v2.14.5",
+  "version": "v2.14.6",
   "description": "Node.js bindings for librdkafka",
   "librdkafka": "1.9.2",
   "main": "lib/index.js",
@@ -43,6 +43,6 @@
     "nan": "^2.17.0"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=6.0.0"
   }
 }