Skip to content

Commit

Permalink
Add Windows and Mac to CI workflow (#998)
Browse files Browse the repository at this point in the history
  • Loading branch information
GaryWilber authored Jan 21, 2023
1 parent 5f0fa56 commit aba2011
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 17 deletions.
32 changes: 24 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test node-rdkafka
name: Build & Test

on:
push:
Expand All @@ -10,16 +10,32 @@ jobs:
build:
strategy:
matrix:
version: [14, 16, 18, 19]
runs-on: ubuntu-latest
node: [14, 16, 18, 19]
os: [ubuntu-22.04]
include:
# single mac test due to minute multipliers
# https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions
- node: 18
os: macos-12
# single windows test due to node.js 14 node-gyp / vs 2022 issues
- node: 18
os: windows-2022
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
with:
submodules: recursive
- uses: actions/setup-node@v3
- name: Install Node ${{ matrix.node }} in ${{ runner.os }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.version }}
node-version: ${{ matrix.node }}
cache: "npm"
- run: npm ci
- run: npm test
name: test
- name: Install Windows packages
if: runner.os == 'Windows'
run: ./win_install.ps1
- name: Build
run: npm ci
# skipping on windows for now due to Make / mocha exit code issues
- name: Test
if: runner.os != 'Windows'
run: npm test
9 changes: 0 additions & 9 deletions win_install.bat

This file was deleted.

2 changes: 2 additions & 0 deletions win_install.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
choco install openssl.light
choco install make

0 comments on commit aba2011

Please sign in to comment.