-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commenting step 1 #39
base: Dev
Are you sure you want to change the base?
Changes from all commits
19b043a
c07bea2
5694ab2
c72fd48
4c54148
9683629
881a117
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
package frc.robot.Other; | ||
|
||
import frc.robot.subsystems.*; | ||
import frc.robot.Constants; | ||
import frc.robot.Robot; | ||
import frc.robot.RobotContainer; | ||
import frc.robot.commands.*; | ||
|
||
/** | ||
* Here, Explanations of How everything works are held. | ||
* | ||
* <p>When Within The class: | ||
* | ||
* <p>{@code - Hover over the Green Part to Get a basic explanation} | ||
* | ||
* <p>{@code - Hover over the Yellow Part for a More Detailed explanation} | ||
* | ||
* <p>{@code - Hover over The Blue Part to find what your getting an Explanation of} | ||
* | ||
* <p>EX: int {@link #DriveTrainExplanation} (Blue) = {@link DriveTrain} (Green) {@link | ||
* DriveTrain#Explanation} (Yellow) | ||
* | ||
* <p>Sub Explanations are down Below: | ||
* | ||
* <ul> | ||
* <li>Init Sendable: | ||
* <ul> | ||
* <li>Sendable objects are things that can be sent to the smart dashboard (WHEN TALKING | ||
* ABOUT FRC!!!!). | ||
* <li>Initializing a sendable object sends that object to the smart dashboard. | ||
* <li>To send other things to the smart dashboard, Use the sendable builder (the thing that | ||
* sends stuff) | ||
* <li>EX: {@link Hanger#initSendable} and {@link DriveTrain#initSendable} | ||
* <li>In order to send variables, you must do {@code builder.addDoubleProperty} (Instead of | ||
* Double do variable type of choice) | ||
* </ul> | ||
*/ | ||
dlezcan1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public class Explanations { | ||
|
||
public abstract class SubsystemExplanations { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is the public abstract class? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dont wont to make an object of it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why make an object out of it at all? Why is this a class? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. want* There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, why is this a class at all? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wanted to make it clear for younger students where all the explanataions would be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would argue that the class implementation is more confusing itself. I think this would be more smoothly implemented with your structure you have in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When people want explanation for things I would like for everything to be in the same place There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you look in Hanger Module The explanation is like a good 200 words that I dont want to be shown when hovering over HangerModule.java There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Break the comments into their individual functions then. |
||
|
||
int DriveTrainExplanation = DriveTrain.Explanation(); | ||
|
||
int HangerExplanation = Hanger.Explanation(); | ||
|
||
int HangerModuleExplanation = HangerModule.Explanation(); | ||
|
||
int IntakeExplanation = Intake.Explanation(); | ||
|
||
int IntakeWheelsExplanation = IntakeWheels.Explanation(); | ||
|
||
int LimelightExplanation = Limelight.Explanation(); | ||
|
||
int ShooterExplanation = Shooter.Explanation(); | ||
|
||
int SwerveModuleExplanation = SwerveModule.Explanation(); | ||
} | ||
|
||
public abstract class RobotExplanations { | ||
|
||
int ConstantsExplanation = Constants.Explanation(); | ||
|
||
int RobotExplanation = Robot.Explanation(); | ||
|
||
int RobotContainerExplanation = RobotContainer.Explanation(); | ||
|
||
// Main.java Is where we initialize our robot. | ||
// It is told which code based (Timed or Command Based or Custom) via the Robot.java class (As | ||
// seen in the Main File) | ||
// DO NOT CREATE ANYTHING IN MAIN.JAVA | ||
|
||
} | ||
|
||
public abstract class CommandExplanation { | ||
|
||
int AprilAlignToSpeakerRadiallyCommandExplanation = | ||
AprilAlignToSpeakerRadiallyCommand.Explanation(); | ||
|
||
int AprilAlignToTransformCommandExplanation = AprilAlignToTransformCommand.Explanation(); | ||
|
||
int AutoIntakeExplanation = AutoIntake.Explanation(); | ||
|
||
int AutoShooterExplanation = AutoShooter.Explanation(); | ||
|
||
int OrientShooterAngleExplanation = OrientShooterAngle.Explanation(); | ||
|
||
int OrientShooterAngleByEncoderValueExplanation = | ||
OrientShooterAngleByEncoderValue.Explanation(); | ||
|
||
int SwerveDriveCommandExplanation = SwerveDriveCommand.Explanation(); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ | |
import edu.wpi.first.wpilibj2.command.Command; | ||
import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
|
||
/** Represents a swerve drive style drivetrain. */ | ||
/** */ | ||
public class DriveTrain extends SubsystemBase { | ||
|
||
public SwerveDriveKinematics m_kinematics = | ||
|
@@ -69,10 +69,15 @@ public class DriveTrain extends SubsystemBase { | |
/** | ||
* Our driveTrain Constructor. | ||
* | ||
* <p>In here, we initialize our swerve modules (example -> {@link #m_frontLeft}), Get input from | ||
* autonomous and initialize our odometry -> {@link #m_odometry}. | ||
* <p>In here, we: | ||
* | ||
* <p>Various other DriveTrain Related thing are initalized here too. | ||
* <ul> | ||
* <li>Initialize our swerve modules (EX: {@link #m_frontLeft}) | ||
* <li>Set up our autonomous builder (see below) | ||
* <li>Initialize our odometry: {@link #m_odometry}. | ||
* </ul> | ||
* | ||
* <p>Various other DriveTrain Related things are initalized here too. | ||
* | ||
* @param RobotVersion | ||
*/ | ||
|
@@ -292,7 +297,7 @@ public void driveChassisSpeeds(ChassisSpeeds chassisSpeed) { | |
/** | ||
* Resets the Position of the Odometer, given our Current position. | ||
* | ||
* @param Pose2d (pose2d) - The current position of the robot on the field. This is a {@link | ||
* @param pose2d (pose2d) - The current position of the robot on the field. This is a {@link | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typical format is param name (Parameter's Class). change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I intended to do that but misclicked apparently There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. Will resolve comment when addressed. |
||
* #resetOdometry(Pose2d)} | ||
*/ | ||
public void resetPose(Pose2d pose2d) { | ||
|
@@ -425,4 +430,9 @@ public void initSendable(SendableBuilder builder) { | |
m_backLeft.initSendable(builder); | ||
m_backRight.initSendable(builder); | ||
} | ||
|
||
/** <b> DETAILED EXPLANATION </b> */ | ||
public static int Explanation() { | ||
return 1; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Created a function called explanation in each class. in the explanation file people will get a clear explanation of how things work based off of the java doc of that explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a function rather a direct comment block with the class and comment blocks for each of the functions? Why use this arbitrary
Explanation
function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt want to make the explanation for the class to long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should focus more on comment blocks, rather than this
Explanation
class system. I would revert these commits and go with comment blockingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also We need to have explanations for things like init Sendable and command schedule and auto etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those can be done for the
initSendable
functions, individuallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about command Scheduler etc. I want to make it so that each student who wants to code after me knows exactly where to look for stuff. I cant java doc the init sendable stuff really and command scheduler stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take this to the main comment block. I'll respond there.