feat: update zevm connector to accept zeta in onreceive #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresaiello
requested review from
brewmaster012,
lumtis,
CharlieMc0 and
fadeev
as code owners
kingpinXD
reviewed
Apr 18, 2024
kingpinXD
approved these changes
Apr 18, 2024
lumtis
approved these changes
Apr 19, 2024
andresaiello
deleted the
andy/pd-6027-feat-update-zevm-connector-to-accept-zeta-in-onreceive-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now the logic in zevm connector for onReceive and onRevert is:
1- Send ZETA from fungible module to connector
2- Call onReceive (or onRevert) from fungible module
The problem with this approach is if onReceive call fail, the tokens are already in connector and we can't get it back.
To solve this both method should be payable and will be only one tx.