Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update cctx status to object to split error message into error and revert_error #3326

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

resolve comments

afe7be1
Select commit
Loading
Failed to load commit list.
Open

refactor: update cctx status to object to split error message into error and revert_error #3326

resolve comments
afe7be1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

62.49% (+0.58%) compared to 2edfa9c

View this Pull Request on Codecov

62.49% (+0.58%) compared to 2edfa9c

Details

Codecov Report

Attention: Patch coverage is 88.97638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 62.49%. Comparing base (2edfa9c) to head (afe7be1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...hain/keeper/cctx_orchestrator_validate_outbound.go 76.08% 11 Missing ⚠️
x/fungible/keeper/evm.go 81.81% 2 Missing ⚠️
x/crosschain/keeper/evm_deposit.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3326      +/-   ##
===========================================
+ Coverage    61.91%   62.49%   +0.58%     
===========================================
  Files          445      450       +5     
  Lines        31501    31771     +270     
===========================================
+ Hits         19503    19855     +352     
+ Misses       11127    11030      -97     
- Partials       871      886      +15     
Files with missing lines Coverage Δ
x/crosschain/keeper/cctx_gateway_observers.go 100.00% <100.00%> (ø)
x/crosschain/keeper/cctx_gateway_zevm.go 100.00% <100.00%> (ø)
x/crosschain/keeper/initiate_outbound.go 66.66% <100.00%> (ø)
x/crosschain/keeper/msg_server_abort_stuck_cctx.go 100.00% <100.00%> (ø)
x/crosschain/keeper/msg_server_vote_outbound_tx.go 90.22% <100.00%> (+0.22%) ⬆️
x/crosschain/types/cctx.go 48.54% <100.00%> (+1.01%) ⬆️
x/crosschain/types/status.go 100.00% <100.00%> (+4.34%) ⬆️
x/fungible/keeper/zevm_msg_passing.go 100.00% <100.00%> (ø)
x/fungible/types/evm_error_message.go 100.00% <100.00%> (ø)
x/crosschain/keeper/evm_deposit.go 87.70% <0.00%> (ø)
... and 2 more

... and 29 files with indirect coverage changes