-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve linter, formatter config #613
Conversation
1. Streamline by switching eslint-config-atomic -> @typescript-eslint. 2. Allow prettier config to be run separately and use `.prettierrc` to ignore yaml and md files. 3. Bump prettier. Prettier 3 automatically ignores .gitignore'd files. Also prettier introduces a breaking change on nearly every release.
{ | ||
"extends": [ | ||
"../.eslintrc", | ||
"eslint-config-atomic/strict", | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eslint-config-atomic already supports TypeScript and more underneath
https://github.com/atom-community/eslint-config-atomic/blob/master/src/typescript.cts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It also pulls in a ton of other stuff (including conflicting peer dependencies)
eslint-config-atomic
is failing CI and I suspect it will have trouble with eslint 9.- It's not clear which rules are in use and why. ZeroMQ is not part of the Atom project.
What particular rules from eslint-config-atomic
am I missing that add value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you separate the Prettier change into a separate PR? I'm not sure if I want to downgrade the linter config from eslint-config-atomic.
I'll be happy to, eventually. Right now, this PR really still belongs in draft status. I'm confused by the entanglement between prettier and eslint.
|
.prettierrc
to ignore yaml and md files.Note I did not migrate to eslint 9 with the new flat config setup, but it seems a reasonable next step.