Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle issues during zbeacon socket preparations #159

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

papr
Copy link
Contributor

@papr papr commented Jul 29, 2021

Possible workaround for #137

@keent keent merged commit 7e8f388 into zeromq:master Jul 29, 2021
@papr papr deleted the handle-beacon-socket-fail branch July 29, 2021 13:22
@papr
Copy link
Contributor Author

papr commented Jul 29, 2021

@keent Could you please trigger a manual version bump via https://github.com/zeromq/pyre/actions/workflows/bump_version.yml ?

@keent
Copy link
Member

keent commented Jul 29, 2021

@papr Bump version fails with :

Run ad-m/github-push-action@master
Push to branch master
Missing input "github_token: ${{ secrets.GITHUB_TOKEN }}".
Error: Invalid exit code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/ad-m/github-push-action/master/start.js:29:21)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5) {
  code: 1
}
Error: Invalid exit code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/ad-m/github-push-action/master/start.js:29:21)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)

@papr
Copy link
Contributor Author

papr commented Jul 29, 2021

https://github.com/zeromq/pyre/actions/runs/1078679721 this run was triggered by closing the PR which fails because the external repo PRs do not have access to the github token. You need to do a manual dispatch of the action https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

@keent
Copy link
Member

keent commented Jul 30, 2021

@papr OK Done. Why is it missing the "build the source" and "deploy to Pypi" steps? Thanks

@papr
Copy link
Contributor Author

papr commented Jul 30, 2021

Mmh, https://github.com/zeromq/pyre/actions/workflows/deploy.yml should be automatically triggered by new tags. Maybe, the bump version commit needs to use the personal access token for auth? :-/

https://github.com/zeromq/pyre/actions/workflows/deploy.yml can be triggered, manually, too, though.

@papr
Copy link
Contributor Author

papr commented Aug 24, 2021

@keent Could you please try triggering https://github.com/zeromq/pyre/actions/workflows/deploy.yml manually?

@keent
Copy link
Member

keent commented Aug 24, 2021

image

@papr
I'm not able to see where I can click manual deploy

@keent
Copy link
Member

keent commented Aug 24, 2021

image

status @papr

@papr
Copy link
Contributor Author

papr commented Aug 24, 2021

@keent Yeah, I think we have to say goodbye to the idea of fully automated deployment for now. You should now be able to manually trigger the deployment for 0.3.4. No need to bump the version to 0.3.5 IMO.
Screenshot 2021-08-24 at 14 37 55

@keent
Copy link
Member

keent commented Aug 28, 2021

@papr Forgot to say. But this was done
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants