Remove 0xf6 empty memo convention. #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
remove_f6_memos
branch
from
697129b to
752986f
Compare
This is a standard convention for Zcash memos, but it doesn't have any relevance to the general Orchard protocol and as such doesn't belong in this crate.
nuttycom
force-pushed
the
remove_f6_memos
branch
from
752986f to
867c33d
Compare
daira
reviewed
Dec 12, 2024
| @@ -342,7 +338,7 @@ impl OutputInfo { | |||
| let fvk: FullViewingKey = (&SpendingKey::random(rng)).into(); | |||
| let recipient = fvk.address_at(0u32, Scope::External); | |||
|
|
|||
| Self::new(None, recipient, NoteValue::zero(), None) | |||
| Self::new(None, recipient, NoteValue::zero(), [0u8; 512]) | |||
There was a problem hiding this comment.
This technically changes the behaviour of this function. Since the FVK/IVK that could read the note plaintext is not available to any other party, it doesn't leak that a version of librustzcash past this PR is being used by the sender. Still a bit weird for something that is supposed to be a pure refactoring, though.
There was a problem hiding this comment.
It's not a pure refactoring, strictly speaking; it is a behavior change. The alternative here would be to just inject random data? But since this then ends up encrypted to a random recipient, I don't think it matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a standard convention for Zcash memos, but it doesn't have any relevance to the general Orchard protocol and as such doesn't belong in this crate.