migrating some of the file stuff to std::filesystem, in the naive hope of getting better cross-platform compatibility #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related #240, should fix "check include paths" feature for windows, and simplify somewhat code base (and get rid of home-made filename patching functions, they seem robust enough and well tested, but I assume in the long term having C++ standard library implementation is better, even if it involves slightly more machine code executed here and there). This is not thorough refactoring of whole code base, working on it bit by bit, luckily the std::filesystem API is flexible enough to connect/disconnect it to rest of code through char[] fields, so I can replace the code partially and check test results. Commit v2 (replacing lot more variables and code than first proof of concept).
ped7g
force-pushed
the
std_fs_attempt
branch
2 times, most recently
from
36423ed to
1d417e4
Compare
Making parser Get[Output]FileName to use std::filesystem::path hopefully everywhere. This get still degraded to std::string/const char* when include paths are involved (GetPath, ArchiveFilename, Open/Include anything). But committing this as intermittent step just in case I will be unable to develop this further soon or if I need rollback to working version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #240 - migrating to std::filesystem goodies, parsing source and saving output files is now fully
std::filesystem::path, include directories are checked by std::filesystem too.Opening files (for various includes) is still degrading path to strings and operating upon them with old implementation, I have some idea how to rewrite it, starting with filename archive becoming
std::set<...::path>and returning iterators to it (dereference those to get path/string), maybe even opening the file for "rb" automatically.Needs more research and reshuffling of current code, so this will come as "part two".
But merging this part already to get working windows builds on master branch, this is technically fully working prod-quality version, as it should be with master branch head.