feat(cli): Add private-key to deposit to batcher #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianVentura
approved these changes
Jan 8, 2025
avilagaston9
approved these changes
Jan 9, 2025
batcher/aligned/src/main.rs
Outdated
| let keystore_path = &submit_args.keystore_path; | ||
| let private_key = &submit_args.private_key; | ||
| let keystore_path = &submit_args.private_key_type.keystore_path; | ||
| let private_key = &submit_args.private_key_type.private_key; | ||
|
|
||
| if keystore_path.is_some() && private_key.is_some() { |
There was a problem hiding this comment.
We can remove this check
uri-99
requested changes
Jan 9, 2025
PatStiles
force-pushed
the
feat/add_private_key_to_deposit_to_batcher
branch
from
13f1ac7 to
9835802
Compare
PatStiles
force-pushed
the
feat/add_private_key_to_deposit_to_batcher
branch
from
9835802 to
1c4e019
Compare
uri-99
reviewed
Jan 10, 2025
batcher/aligned/src/main.rs
Outdated
| } else { | ||
| warn!("Missing keystore used for payment."); | ||
| return Ok(()); | ||
| warn!("Missing keystore used for payment. This proof will not be included if sent to Eth Mainnet"); |
There was a problem hiding this comment.
this param is required == true so this can't happen.
Also I don't think it makes much sense to add this
uri-99
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add private-key to deposit to batcher
Description
Addresses the second item of #1568.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging