feat(alerts): Display the number of proofs in a batch from the created task #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuArce
requested changes
Jan 9, 2025
There was a problem hiding this comment.
All this changes are not related with the PR
PatStiles
force-pushed
the
feat/number_proofs_in_sender_with_alert
branch
from
8325d76 to
1d8846a
Compare
|
Closing in favor of #1727 as this branch was made off staging and carries with it some of the commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the number of proofs in a batch from the created task
Description
Currently the alert sender just sends the number of repetitions of sent proofs. This pr changes this to fetch the number of proof submitters in the batch from the
proofSubmittersparameter of thecreateNewTaskfunction call. This parameters contains the addresses of each submitted proof therefore the number of submitters corresponds to the number of proofs in the batch.To Test:
./alerts/sender_with_alert.sh ./alerts/.envYou should observe that the correct number of proofs in a batch is displayed now and observe that if a second senders proofs are included in the batch the number of proofs are displayed. Adding additional task senders should increase the batch size.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging