-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add latency metrics to batcher #1578
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also i would separate the latencies in grafana in a different section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and seems to work as expected. I'm just leaving a comment because of curiosity
Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com>
Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com>
Add Latency Metrics to Batcher
Description
Adds the following metrics to the Batcher:
S3 Latency
: Measures the time it takes to upload the batch to S3.CreateNewTask Latency
: Measures the time theCreateNewTask
function takes. It is broken down into two:create_new_task
: Time it takes to send the new task to Ethereum.cancel_new_task
: Time it takes to cancel the new task, in case the receipt is not found.Note
The time shown is always the latest one.
cancel_new_task
is set to zero since sometimes the function is not executed.Note
It always takes 7 secs to get a receipt from anvil.
How to Test
localhost:3000
and watch theSystem Data
dashboard.You can also edit the Batcher code to emit some
cancel_new_task
events:batcher/aligned-batcher/src/lib.rs
file in line1569
as follows:Type of change
Checklist
testnet
, everything else tostaging