Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nunjucks.md #753

Closed
wants to merge 2 commits into from
Closed

Conversation

jaysunwalter123
Copy link

This could do with improvement I'm sure but it's working for me thus far. I'm not at all a js pro, I slowly worked through it, converting from the old recipe as well as I could. Because I don't fully understand what every little bit does my commenting is a little incomplete. Hopefully this will help anyone else that relies on this setup that I personally have used for years.

This could do with improvement I'm sure but it's working for me thus far. I'm not at all a js pro, I slowly worked through it, converting from the old recipe as well as I could. Because I don't fully understand what every little bit does my commenting is a little incomplete. Hopefully this will help anyone else that relies on this setup that I personally have used for years.
Update Watch task to use 'views' instead of 'viewsreload'. The HTML was not being updated in the .tmp file.
Copy link
Member

@silvenon silvenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason! This is looking pretty good, some more updates are necessary, though 😃

docs/recipes/nunjucks.md Show resolved Hide resolved
docs/recipes/nunjucks.md Show resolved Hide resolved
docs/recipes/nunjucks.md Show resolved Hide resolved
@UlisesGascon
Copy link
Member

Maybe this PR was the same as #766. Should we remix and merge them in a separate branch, @silvenon ? I can handle that if you agree 👍

@silvenon
Copy link
Member

Since we merged another PR that updated the Nunjucks recipe, I'll close this, but congratulations for the contribution @jaysunwalter123!

@silvenon silvenon closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants