Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce Connector implemented #1199

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Nov 12, 2020

Partially resolves #1093

Summary checklist

  • deleted_post callback tested and passing.
  • transition_post_status callback tested and passing.
  • woocommerce_attribute_added callback tested and passing.
  • woocommerce_attribute_deleted callback tested and passing.
  • woocommerce_attribute_updated callback tested and passing.
  • woocommerce_order_status_changed callback tested and passing.
  • woocommerce_tax_rate_added callback tested and passing.
  • woocommerce_tax_rate_deleted callback tested and passing.
  • woocommerce_tax_rate_updated callback tested and passing.
  • updated_option callbacks tested and passing. Stubbed.

@kidunot89 kidunot89 requested review from kasparsd and dero November 12, 2020 20:44
@kidunot89 kidunot89 self-assigned this Nov 12, 2020
'%1$s status changed from %2$s to %3$s',
'1. Order title, 2. Old status, 3. New status',
'stream'
$order = new \WC_Order( $order_id );
Copy link
Contributor

@lkraav lkraav Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly certain current convention is to use getters, in this case wc_get_order()

@kidunot89 kidunot89 force-pushed the tests/woocommerce-connector branch from 27137cd to eaef22f Compare December 15, 2020 21:11
@kidunot89 kidunot89 added this to the 3.7.0 milestone Feb 8, 2021
@kidunot89 kidunot89 force-pushed the tests/woocommerce-connector branch from eaef22f to fc87e69 Compare February 10, 2021 16:25
@kidunot89 kidunot89 force-pushed the tests/woocommerce-connector branch from fc87e69 to f6bb6bf Compare February 10, 2021 16:41
@kidunot89 kidunot89 changed the title WIP WooCommerce Connector implemented WooCommerce Connector implemented Feb 10, 2021
@kidunot89 kidunot89 mentioned this pull request Feb 22, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Test Coverage
2 participants