[CI] Fix the comment prefix. #20728
[CI] Fix the comment prefix. #20728
Conversation
mandel-macaque
force-pushed
the
fix-comment-prefix
branch
from
0c9ae3b to
2886f76
Compare
Becuse the tests do not longer run as a PR trigger we lost the way to know if we are a PR build based on the env variables. We set the IS_PR env variable passed in the templates to be able to know and set the correct prefix.
mandel-macaque
force-pushed
the
fix-comment-prefix
branch
from
2886f76 to
7ea3695
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 168 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
| @@ -104,7 +104,7 @@ class GitHubStatuses { | |||
| } | |||
|
|
|||
| [string] GetStatusPrefix() { | |||
| if ($Env:BUILD_REASON -eq "PullRequest") { | |||
| if ($Env:BUILD_REASON -eq "PullRequest" -or $Env:IS_PR -eq "True") { | |||
There was a problem hiding this comment.
We already have an IsPR function, so it would be better to just use that:
| if ($Env:BUILD_REASON -eq "PullRequest" -or $Env:IS_PR -eq "True") { | |
| if (IsPR()) { |
| @@ -283,7 +283,7 @@ class GitHubComments { | |||
| return | |||
| } | |||
|
|
|||
| if ([string]::IsNullOrEmpty($Env:PR_ID)) { | |||
| if ([string]::IsNullOrEmpty($Env:PR_ID) -or $Env:IS_PR -ne "True") { | |||
There was a problem hiding this comment.
| if ([string]::IsNullOrEmpty($Env:PR_ID) -or $Env:IS_PR -ne "True") { | |
| if (-not IsPr()) { |
| @@ -264,7 +264,7 @@ class GitHubComments { | |||
| } | |||
| } | |||
|
|
|||
| return $false | |||
| return $Env:IS_PR -eq "True" | |||
There was a problem hiding this comment.
Note that I changed this function to check the branch name, which may be enough to properly detect if we're in a PR: f0d4375#diff-289ba09865f46d8622d3bf5deb2d0e4e86112883230745baf7fc2018f6b7f905R260-R265
Becuse the tests do not longer run as a PR trigger we lost the way to know if we are a PR build based on the env variables. We set the IS_PR env variable passed in the templates to be able to know and set the correct prefix.